Link stdc++fs #546
Open
Link stdc++fs #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This contains a lot of changes that are not related at all to what you are describing. Did you mangle this with some other PR? |
|
I messed up the base branch, sorry. |
This seems to be necessary for older compilers (e.g. gcc 8.5 on RHEL8)
fmauch
force-pushed
the
link_stdc++fs
branch
4 times, most recently
from
85f22cf
to
ddaecd2
Compare
|
I've been playing around with an RHEL workflow, but it seems to be failing on installing dependencies that should be there, see https://github.com/fmauch/Universal_Robots_ROS2_Driver/actions/runs/3536558367/jobs/5935691095. Edit: It should not necessarily be there. http://packages.ros.org/ros2/rhel/8/x86_64/Packages/r/ does not contain the package. Since the sync should be going on right now, this will probably resolve itself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be necessary for older compilers (e.g. gcc 8.5 on RHEL8)
See e.g. https://build.ros2.org/job/Hbin_rhel_el864__ur_calibration__rhel_8_x86_64__binary/23/console
This might be necessary for rolling, as well, but for rolling a lot of upstream dependencies are missing on RHEL before this gets relevant.
It might be beneficial to add RHEL builds to our pipeline based on https://github.com/ros-controls/ros2_rhel