-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish joint temperature #446
base: master
Are you sure you want to change the base?
Conversation
Please see #35 I'd like to get this fixed all together. |
I can understand that this PR is way more general, but is it actually still work in progress, cause it seems a bit stalled. |
That's right. That also means, that any help in this would be very appreciated :-) |
Ok got it. I will see if I can somehow contribute there then. Feel free to close this pull request then, and in case someone needs urgently temperature measurements, they can check out the corresponding branch. |
That's why I would leave it open. It would be awesome if you could contribute to #35 I would very much like to get this done, but couldn't find the time to tackle it, yet. |
This PR hasn't made any progress for quite some time and will be closed soon. Please comment if it is still relevant. |
please keep. |
This PR hasn't made any progress for quite some time and will be closed soon. Please comment if it is still relevant. |
Since we need temperature information on the motor level for parameters identification, I implemented publishers for publishing the joint temperature as retrieved by the driver. I am making a pull request in case this would be useful for others too, and to get some feedback on my implementation.
Based on previous discussions at #35 and ros-industrial-attic/ur_modern_driver#81, I used the
sensor_msgs::Temperature
message type and constructed a publisher for each joint. I have two questions:frame_id
. Is this indeed the case? What would be the most convenient way to retrieve link names?