Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to :sp/:vs open non-existing files. #8698

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Conversation

JLMSC
Copy link
Contributor

@JLMSC JLMSC commented Oct 27, 2023

What this PR does / why we need it:
Fixes the use of :sp/:vs with non-existing files, opening a new split with the specified file and creating it right away (the file will need to be manually saved to apply changes).

Which issue(s) this PR fixes
Fixes #7283
Partially fixes #8671

@J-Fields J-Fields merged commit 2dabb80 into VSCodeVim:master Oct 27, 2023
@J-Fields
Copy link
Member

Thanks!

@dsharma29
Copy link

Problem:

With this change now when we only type :vsp to split the opened file it creates a new file always. Now we have to type the entire filename to be able to split it.

Solution:

This change should check if a file name is not specified it should split the opened file and not create a new one. It should create a new one only when a filename is specified which does not exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

not support ":sp test.md", ":ls", ":pwd" command :vs/:sp can't open non-existing files.
3 participants