Add 5m timeout to page.WaitForRequest #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #1153 +/- ##
==========================================
+ Coverage 39.06% 39.11% +0.05%
==========================================
Files 53 53
Lines 7966 7973 +7
==========================================
+ Hits 3112 3119 +7
Misses 4440 4440
Partials 414 414
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@kbarlowgw How about I think you need find a way for this path |
|
Thanks... I pushed an update that will hopefully fix it. It went from
46.7% to 48.9% locally:
ok github.com/versent/saml2aws/v2/pkg/provider/browser 1.935s coverage:
48.9% of statements
Please let me know if there's anything else required.
Keith
…On Thu, Oct 26, 2023 at 8:24 PM Mark Gerard ***@***.***> wrote:
@kbarlowgw
<https://github.com/kbarlowgw>
How about browser_test.go?
I think you need find a way for this path playwright.PageWaitForRequestOptions{Timeout:
&timeout} to be exercised so that test coverage is not affected.
—
Reply to this email directly, view it on GitHub
<#1153 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BBG2EVBNHHSTO773RBZP57DYBL5LFAVCNFSM6AAAAAA6RMV54CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBSGEYTAMZZG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
mapkon
approved these changes
Oct 31, 2023
|
Any chance this could be made configurable via e.g. command line switch? |
|
I can look into that.
Keith
…On Tue, Oct 31, 2023 at 10:39 AM Alessandro Diaferia < ***@***.***> wrote:
Any chance this could be made configurable via e.g. command line switch?
—
Reply to this email directly, view it on GitHub
<#1153 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BBG2EVAESE5LAR33LOSOTJLYCEEQVAVCNFSM6AAAAAA6RMV54CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBXGM2TENJYHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
It looks to me that the existing timeout field in the account settings was
unused in browser configurations so I mapped that to the timeout for
Page.WaitForRequest. If the timeout is set less than 30s, the default of 5
mins will be used. It seems pointless to allow timeouts less than the
default provided by playwright. Unit tests have been added & updated.
Keith
…On Tue, Oct 31, 2023 at 12:00 PM Keith Barlow ***@***.***> wrote:
I can look into that.
Keith
On Tue, Oct 31, 2023 at 10:39 AM Alessandro Diaferia <
***@***.***> wrote:
> Any chance this could be made configurable via e.g. command line switch?
>
> —
> Reply to this email directly, view it on GitHub
> <#1153 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/BBG2EVAESE5LAR33LOSOTJLYCEEQVAVCNFSM6AAAAAA6RMV54CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBXGM2TENJYHE>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
|
Thanks, all!
Keith
…On Tue, Oct 31, 2023 at 11:34 PM Mark Gerard ***@***.***> wrote:
Merged #1153
<#1153>
into master.
—
Reply to this email directly, view it on GitHub
<#1153 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BBG2EVHC3R7SQE5J4VEFM5TYCG7LRAVCNFSM6AAAAAA6RMV54CVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJQHAZDOOJXHE4DIMQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
This change works great for me. What needs to happen to get this in the next release? |
|
I just need to cut a release. I am looking to a window to do that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't see an appropriate place to add/update a unit test for this but I have been using it locally and it fixes the issue. Doesn't seem like an external configuration flag is required but may be if users continue to have issues.