Trivial readability changes to scheduling-tasks doc #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaseley
requested changes
Apr 25, 2024
spec/scheduling-tasks.md
Outdated
| @@ -148,7 +148,7 @@ A <dfn>scheduler task</dfn> is a [=/task=] with an additional numeric | |||
| The following [=task sources=] are defined as <dfn>scheduler task sources</dfn>, | |||
| and must only be used for [=scheduler tasks=]. | |||
|
|
|||
| : <dfn>The posted task task source</dfn> | |||
| : <dfn>The posted task's task source</dfn> | |||
There was a problem hiding this comment.
Not sure about this. This is defining a specific type of task source, i.e. the task source to use for tasks scheduled with the postTask API, and the possession doesn't really fit here (it's a category, so singular possession doesn't make sense to me). Probably "The" should move out of the definition though, and maybe we could consider renaming since we'll probably share this with yield.
There was a problem hiding this comment.
Remembering back, the name was inspired by the posted message task source, which is analogous.
There was a problem hiding this comment.
Yeah I wasn't sure. I reverted but moved the out, and will let you consider rename later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff