Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivial readability changes to scheduling-tasks doc #90

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Trivial readability changes to scheduling-tasks doc #90

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90e1a65
Trivial readability changes to scheduling-tasks doc
mmocny Apr 25, 2024
88ee673
address comments
mmocny Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions spec/scheduling-tasks.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ used for tasks that are blocking the user's ability to interact with the page, s
core experience or responding to user input.

<dfn enum-value for=TaskPriority>user-visible</dfn> is the second highest priority, and is meant to
be used for tasks that visible to the user but not necessarily blocking user actions, such as
rendering secondary parts of the page. This is the default priority.
be used for tasks that are observable to the user but not necessarily blocking user actions, such as
updating secondary parts of the page. This is the default priority.

<dfn enum-value for=TaskPriority>background</dfn> is the lowest priority, and is meant to be used
for tasks that are not time-critical, such as background log processing or initializing certain
Expand Down Expand Up @@ -110,7 +110,7 @@ Note: We implement *dynamic prioritization* by enqueuing tasks associated with a
response to `prioritychange` events. The [=Scheduler/dynamic priority task queue map=] holds the
[=scheduler task queues=] whose priorities can change, and the map key is the {{TaskSignal}} which
all tasks in the queue are associated with.
<br/></br>
<br/><br/>
The values of the [=Scheduler/static priority task queue map=] are [=scheduler task queues=] whose
priorities do not change. Tasks with *static priorities* &mdash; those that were scheduled with an
explicit {{SchedulerPostTaskOptions/priority}} option or a {{SchedulerPostTaskOptions/signal}}
Expand Down Expand Up @@ -148,7 +148,7 @@ A <dfn>scheduler task</dfn> is a [=/task=] with an additional numeric
The following [=task sources=] are defined as <dfn>scheduler task sources</dfn>,
and must only be used for [=scheduler tasks=].

: <dfn>The posted task task source</dfn>
: The <dfn>posted task task source</dfn>
:: This [=task source=] is used for tasks scheduled through {{Scheduler/postTask()}}.

<br/>
Expand Down Expand Up @@ -274,7 +274,7 @@ Issue: [=Run steps after a timeout=] doesn't necessarily account for suspension;
1. Let |enqueue order| be |scheduler|'s [=Scheduler/next enqueue order=].
1. Increment |scheduler|'s [=Scheduler/next enqueue order=] by 1.
1. Let |task| be the result of [=queuing a scheduler task=] on |queue| given |enqueue order|,
[=the posted task task source=], and |document|, and that performs the following steps:
the [=posted task task source=], and |document|, and that performs the following steps:
1. Let |callback result| be the result of [=invoking=] |callback|. If that threw an exception,
then [=reject=] |result| with that, otherwise resolve |result| with |callback result|.
1. If |signal| is not null, then [=AbortSignal/add|add the following=] abort steps to it:
Expand Down