Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify markup for internal references #1391

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dontcallmedom
Copy link

@dontcallmedom dontcallmedom commented Jan 30, 2025

otherwise, this has the spec have a normative reference to itself


Preview | Diff

otherwise, this has the spec have a normative reference to itself
Copy link
Collaborator

@qingxinwu qingxinwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, % a few formatting nits.

Comment on lines +4740 to 4741
group set=] whose [=interest group/owner=] is
|buyerOrigin|.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
group set=] whose [=interest group/owner=] is
|buyerOrigin|.
group set=] whose [=interest group/owner=] is |buyerOrigin|.

Comment on lines +4744 to 4745
[=interest group/owner=] is
|buyerOrigin|.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[=interest group/owner=] is
|buyerOrigin|.
[=interest group/owner=] is |buyerOrigin|.

Comment on lines +4749 to 4750
[=interest group/owner=] is
|buyerOrigin|.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[=interest group/owner=] is
|buyerOrigin|.
[=interest group/owner=] is |buyerOrigin|.

@qingxinwu qingxinwu added the spec Relates to the spec label Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec Relates to the spec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants