Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify markup for internal references #1391

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Simplify markup for internal references #1391

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc75f3c
Simplify markup for internal references
dontcallmedom Jan 30, 2025
e26f384
Adjust space wrapping
dontcallmedom Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 9 additions & 14 deletions spec.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4736,19 +4736,15 @@ an [=auction config=] |auctionConfig| and a [=reporting context=] |reportingCont
|reportType|:
<dl class="switch">
: "`interestGroupCount`"
:: The number of interest groups in the [=user agent=]'s <a
spec="turtledove">interest group set</a> whose <a
spec="turtledove" for="interest group">owner</a> is
|buyerOrigin|.
:: The number of interest groups in the [=user agent=]'s [=interest
group set=] whose [=interest group/owner=] is |buyerOrigin|.
: "`bidCount`"
:: The number of valid bids generated by interest groups whose <a
spec="turtledove" for="interest group">owner</a> is
|buyerOrigin|.
:: The number of valid bids generated by interest groups whose
[=interest group/owner=] is |buyerOrigin|.
: "`totalGenerateBidLatency`"
:: The sum of execution time in milliseconds for all `generateBid()`
calls in the auction for interest groups whose <a
spec="turtledove" for="interest group">owner</a> is
|buyerOrigin|.
calls in the auction for interest groups whose
[=interest group/owner=] is |buyerOrigin|.
: "`totalSignalsFetchLatency`"
:: The total time spent fetching trusted buyer signals in
milliseconds, or 0 if the interest group didn't fetch any
Expand Down Expand Up @@ -4777,9 +4773,8 @@ an [=auction config=] |auctionConfig| and a [=reporting context=] |reportingCont
:: 0

Issue: Consider allowing the filtering ID to be set here.
1. [=map/For each=] |ig| of the [=user agent=]'s <a spec="turtledove">
interest group set</a> whose
<a spec="turtledove" for="interest group">owner</a> is |buyerOrigin|:
1. [=map/For each=] |ig| of the [=user agent=]'s [=interest group set=] whose
[=interest group/owner=] is |buyerOrigin|:
1. If seller capabilities of |ig| don't allow this reporting, [=iteration/continue=].

Issue: Align behavior with seller capabilities handling once <a
Expand Down Expand Up @@ -4892,7 +4887,7 @@ They return a {{double}}.
</dl>
: "<code>[=signal base value/bid-reject-reason=]</code>"
:: 1. If the bid did not succeed purely because it didn't meet the required
<a spec="turtledove">k-anonymity threshold</a>, return 8.
[=k-anonymity threshold=], return 8.
1. Let |bidRejectReason| be "`not-available`".
1. If the seller provided a reject reason, set |bidRejectReason| to that
value.
Expand Down