Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview not working on forks #41

Closed
juanfra opened this issue Oct 24, 2024 · 5 comments · Fixed by #43
Closed

Preview not working on forks #41

juanfra opened this issue Oct 24, 2024 · 5 comments · Fixed by #43

Comments

@juanfra
Copy link
Member

juanfra commented Oct 24, 2024

Description

While testing PRs in Twenty Twenty-Five, I've noticed that the link of this action works when the branch is part of the "parent" repository. If a contributor forks the repository, and then creates a PR with their own branch it's not working. Apparently, the theme can't be adequately downloaded in this particular scenario as you can see in the following screencast.

Screen.Recording.2024-10-24.at.08.27.38.mov
@bgrgicak
Copy link
Contributor

This is caused by the repo parameter. It points to the parent repository while it should point to the forked repository.

The repo value comes from here.

I'm not sure what the best way to resolve this is. We need to find a way to point the repository back to the fork.

@bgrgicak
Copy link
Contributor

@juanfra do you have any suggestions how we could resolve this?

@juanfra
Copy link
Member Author

juanfra commented Oct 28, 2024

@bgrgicak, I didn't have time to look at the code. I can try to save some time towards the end of this week, as I have to prioritize things related to Twenty Twenty-Five first.

@bgrgicak
Copy link
Contributor

That would be great, thank you!

@juanfra
Copy link
Member Author

juanfra commented Oct 31, 2024

@bgrgicak I put something together that could fix it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants