Try: Fix preview link in PRs from forks #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgrgicak
reviewed
Nov 4, 2024
bgrgicak
approved these changes
Nov 4, 2024
|
Thank you for fixing fork previews @juanfra! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #41
I'm updating the repo name depending on whether it's a fork or not so that the proxy can download the correct theme folder and the preview link works for PRs coming from forks.
Screen.Recording.2024-10-31.at.12.55.17.mov
You can see the changes in action in the following PR.
Bonus: Updated the inclusion of preferred versions only if there is a value.