Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e tests #82

Closed
wants to merge 0 commits into from
Closed

Add e2e tests #82

wants to merge 0 commits into from

Conversation

reimic
Copy link
Collaborator

@reimic reimic commented Mar 19, 2024

🚧 Work in progress 🚧

What does this PR do?

  • adds e2e tests

todo:

  • set phpunit version to 6.5
  • fix all unit tests to match phpunit == 6.5
  • fix issues uncovered in tests
  • examine why a test failing validation is displayed as passing
  • fix assertions

@reimic reimic self-assigned this Mar 19, 2024
@reimic
Copy link
Collaborator Author

reimic commented Mar 19, 2024

@adamziel it would be cool if you could take a look at supposedly passing tests for PHP == 8.3 (hint - they do not pass):

The CI test Running json blueprint with steps fails at step setSiteOptions, which is quite a surprise. Locally it fails at defineWpConfigConsts which indicates a Windows compatibility issue, again.

The CI test Running json blueprint with word press version fails only because I did not properly prepare what should be asserted. But locally I get an error for step downloadWordPress. Again, most likely a Windows problem...

For php blueprints - all fail at validation. I'll make an issue for that.... and I'll add another one to enhance the quality of errors thrown.

Array
(
    [/constants] => Array
        (
            [0] => The data (array) must match the type: object
        )

)

That's not the most informative thing to get from a validator. We can do better.

@adamziel
Copy link
Collaborator

Let's chat in #83

*
* @return array
*/
public function blueprint_with_word_press_version() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: it’s WordPress, not word_press. Let’s either stick to the correct word or say just wp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants