Map: Add style variations #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iandunn
force-pushed
the
map-styles
branch
2 times, most recently
from
052eb6a
to
be87e0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #505
I looked into embedding the images as
<svg>and using CSSfill, but that looked like it'd require switching to the Advanced Markers API, which would be a bigger scope than we have time for right now. It'd be a good thing to look into for the future, though.Will probably need to merge the Event Filters block like I mentioned in #500 though, to prevent this from breaking the current
/state-of-the-wordstyles. The upstream block can't apply block styles yet