Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple bank-aware malloc scheme #1143

Merged
merged 111 commits into from
Apr 25, 2024
Merged

Simple bank-aware malloc scheme #1143

merged 111 commits into from
Apr 25, 2024

Conversation

AndraBisca
Copy link
Collaborator

@AndraBisca AndraBisca commented Mar 21, 2024

This PR introduces a SimpleBankAwareAllocation scheme to AIEAssignBuffers.cpp that does round-robin allocations across available memory banks. This new memory allocation scheme will be enabled by default while the previous scheme, now called BasicAllocationScheme, can be enabled via the --basic-alloc-scheme flag in aiecc and --basic-alloc in the lowering pass using:

aiecc.py --basic-alloc-scheme
and
aie-opt --aie-assign-buffer-addresses="basic-alloc"

This PR also restructures AIEAssignBuffers.cpp such that future allocation schemes may be easier to add.

This is an improved version of #1108.

@AndraBisca AndraBisca changed the title Simple bank-aware malloc scheme [wip] Simple bank-aware malloc scheme Mar 21, 2024
lib/Dialect/AIE/IR/AIEDialect.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
AndraBisca and others added 9 commits March 21, 2024 17:11
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
lib/Dialect/AIE/IR/AIEDialect.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp Outdated Show resolved Hide resolved
@AndraBisca AndraBisca marked this pull request as ready for review April 25, 2024 13:30
@AndraBisca AndraBisca changed the title [wip] Simple bank-aware malloc scheme Simple bank-aware malloc scheme Apr 25, 2024
Copy link
Collaborator

@denolf denolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackl-xilinx jackl-xilinx merged commit 37dd2a6 into main Apr 25, 2024
54 checks passed
@jackl-xilinx jackl-xilinx deleted the objfifo-alloc branch April 25, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants