Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple bank-aware malloc scheme #1143

Merged
merged 111 commits into from
Apr 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
111 commits
Select commit Hold shift + click to select a range
2a13bc3
Add new attr to ObjectFifoCreateOp to note another objfifo to avoid w…
abisca Mar 18, 2024
7fe8b2a
Matrix multiply works!
abisca Mar 21, 2024
2f3d5ac
Cleanup passes and rename objFifo_name to objFifo_to_avoid_at_alloc
abisca Mar 21, 2024
1b92ef3
Fix merge conflicts
abisca Mar 21, 2024
88071a9
Update lib/Dialect/AIE/Transforms/AIEObjectFifoStatefulTransform.cpp
AndraBisca Mar 21, 2024
7659ce1
Update lib/Dialect/AIE/IR/AIEDialect.cpp
AndraBisca Mar 21, 2024
26deab7
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Mar 21, 2024
0ed53ca
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Mar 21, 2024
78c67c7
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Mar 21, 2024
f96b29f
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Mar 21, 2024
fb8532b
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Mar 21, 2024
f901f24
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Mar 21, 2024
931168e
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Mar 21, 2024
6c99058
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Mar 21, 2024
ecdc85a
Update reference_designs/ipu-xrt/matrix_multiplication/aie2.py
AndraBisca Mar 21, 2024
250750c
Update reference_designs/ipu-xrt/matrix_multiplication/aie2.py
AndraBisca Mar 21, 2024
8b0a5a8
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Mar 21, 2024
efc2e8f
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Mar 21, 2024
37902a7
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Mar 21, 2024
84c4269
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Mar 21, 2024
ec1161b
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Mar 21, 2024
a19dcd8
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Mar 21, 2024
ed6bf0f
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Mar 21, 2024
cba1466
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Mar 21, 2024
2f4fdc2
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Mar 21, 2024
c423327
Merge branch 'main' of https://github.com/Xilinx/mlir-aie into objfif…
abisca Mar 21, 2024
c3441f0
Update tests
abisca Mar 21, 2024
ae09f80
Merge branch 'main' of https://github.com/Xilinx/mlir-aie into objfif…
abisca Mar 22, 2024
105ab31
Fix failing tests
abisca Mar 22, 2024
7554731
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Mar 22, 2024
24003d0
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Mar 22, 2024
4c61125
Function cleanup. Added function descriptions.
abisca Mar 22, 2024
f6b31bb
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Mar 22, 2024
26fd992
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Mar 22, 2024
b88f83f
Fix unit tests
abisca Mar 22, 2024
0003102
Merge branch 'main' of https://github.com/Xilinx/mlir-aie into objfif…
abisca Mar 26, 2024
314215b
Fix merge conflicts
abisca Apr 16, 2024
59306ce
Remove objfifo attr.
abisca Apr 17, 2024
713a3de
Fix errors
abisca Apr 17, 2024
2a35c0c
Update lib/Dialect/AIE/Transforms/AIEObjectFifoStatefulTransform.cpp
AndraBisca Apr 17, 2024
0737cec
Tets flag
abisca Apr 18, 2024
1c5307f
Merge branch 'main' of https://github.com/Xilinx/mlir-aie into objfif…
abisca Apr 22, 2024
24604a3
Create different classes for allocation schemes
abisca Apr 22, 2024
7e3c127
Started cleanup alloc schemes
abisca Apr 22, 2024
6be0d66
Merge branch 'main' of https://github.com/Xilinx/mlir-aie into objfif…
abisca Apr 23, 2024
d8cdb54
Restructure pass with OpConversionPatterns
abisca Apr 23, 2024
a715799
Add missing return failure()
abisca Apr 24, 2024
da83f63
Add tests for both alloc schemes
abisca Apr 24, 2024
2b6ec63
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Apr 24, 2024
e02fd2e
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Apr 24, 2024
9a2289d
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Apr 24, 2024
e72977c
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Apr 24, 2024
fe4aca8
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Apr 24, 2024
8a16dea
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Apr 24, 2024
590f2c7
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Apr 24, 2024
2f47719
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Apr 24, 2024
54682da
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Apr 24, 2024
075dcf5
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Apr 24, 2024
fd20082
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Apr 24, 2024
4abbb80
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Apr 24, 2024
9132f59
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Apr 24, 2024
7481632
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Apr 24, 2024
1bcd415
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Apr 24, 2024
fc8e063
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Apr 24, 2024
f637184
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Apr 24, 2024
80cc5d5
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Apr 24, 2024
bbfb4fc
Update
abisca Apr 24, 2024
fef685a
Final version of the alloc schemes
abisca Apr 24, 2024
8688b68
Clang format
abisca Apr 24, 2024
81cfcb6
Remove missed merge conflict
abisca Apr 24, 2024
f3f7d5f
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Apr 24, 2024
8d41218
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Apr 24, 2024
8e768a7
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Apr 24, 2024
5d3d8ef
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Apr 24, 2024
72ff475
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Apr 24, 2024
2624f0b
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Apr 24, 2024
5e7a38d
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Apr 24, 2024
d3e1f78
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Apr 24, 2024
71465fe
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Apr 24, 2024
d0a3234
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Apr 24, 2024
13093b2
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Apr 24, 2024
3f6a0e8
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Apr 24, 2024
4331c02
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Apr 24, 2024
d7139f9
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Apr 24, 2024
32040aa
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Apr 24, 2024
2524e13
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Apr 24, 2024
92bdd3b
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Apr 24, 2024
9250651
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Apr 24, 2024
cff06b0
Merge branch 'main' of https://github.com/Xilinx/mlir-aie into objfif…
abisca Apr 24, 2024
50a8e4a
Merge branch 'objfifo-alloc' of https://github.com/Xilinx/mlir-aie in…
abisca Apr 24, 2024
28c0de4
Fixed modulesXilinx
abisca Apr 24, 2024
9fd6b84
Add aiecc flag for basic_alloc_scheme
abisca Apr 24, 2024
9926ca1
Merge branch 'main' of https://github.com/Xilinx/mlir-aie into objfif…
abisca Apr 24, 2024
e88bd2b
Update python/compiler/aiecc/main.py
AndraBisca Apr 24, 2024
cca86ff
Merge branch 'objfifo-alloc' of https://github.com/Xilinx/mlir-aie in…
abisca Apr 24, 2024
11a4adc
Add flag where needed
abisca Apr 24, 2024
c2039db
Add flag to test
abisca Apr 24, 2024
b699c42
Attemp to fix tests
abisca Apr 24, 2024
25bc685
Attempt 2
abisca Apr 24, 2024
1efb1ae
Rooting out error
abisca Apr 24, 2024
7912328
Still looking for root cause of errors
abisca Apr 25, 2024
6a880fb
Still looking for root cause of errors
abisca Apr 25, 2024
c60cb3f
Test
abisca Apr 25, 2024
59ac15f
Replace getOps with device.walk to pick up all buffers in device
abisca Apr 25, 2024
c147498
Update lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp
AndraBisca Apr 25, 2024
845b178
Remove flag when not necessary
abisca Apr 25, 2024
155c5a1
Merge branch 'objfifo-alloc' of https://github.com/Xilinx/mlir-aie in…
abisca Apr 25, 2024
3bff413
Merge branch 'main' of https://github.com/Xilinx/mlir-aie into objfif…
abisca Apr 25, 2024
f7eeef5
Fix tests
abisca Apr 25, 2024
fdf18aa
Fix copyrights
abisca Apr 25, 2024
b688633
Merge branch 'main' of https://github.com/Xilinx/mlir-aie into objfif…
abisca Apr 25, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion include/aie/Dialect/AIE/IR/AIEOps.td
Original file line number Diff line number Diff line change
Expand Up @@ -1258,7 +1258,8 @@ def AIE_BufferOp: AIE_Op<"buffer", [
ins Index:$tile,
OptionalAttr<StrAttr>:$sym_name,
OptionalAttr<AIEI32Attr>:$address,
OptionalAttr<ElementsAttr>:$initial_value
OptionalAttr<ElementsAttr>:$initial_value,
OptionalAttr<AIEI32Attr>:$mem_bank
);

let results = (outs AnyMemRef:$buffer);
Expand Down
5 changes: 5 additions & 0 deletions include/aie/Dialect/AIE/Transforms/AIEPasses.td
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,11 @@ def AIEAssignBufferAddresses : Pass<"aie-assign-buffer-addresses", "DeviceOp"> {
}];

let constructor = "xilinx::AIE::createAIEAssignBufferAddressesPass()";

let options = [
Option<"clBasicAlloc", "basic-alloc", "bool", /*default=*/"false",
"Flag to enable the basic sequential allocation scheme (not bank-aware).">
];
}

def AIEAssignLockIDs : Pass<"aie-assign-lock-ids", "DeviceOp"> {
Expand Down
Loading
Loading