Don't remove namespaces from attributes #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! The string allocations are unlikely to be a problem in light of all the other allocations done while parsing. |
|
@aantron Do you plan to make an OPAM release with this change in the near future? |
|
Yes! In fact, immediately :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very naive implementation of including the namespace in attribute names.
Could lead to performance and memory problems when a lot of namespaced attributes are present, since this creates a new string for each attribute.
There might be an argument for changing the API of
Markupinstead, but this was the most straightforward fix I could think of.Fixes #12