UV-267 - CoAP proxy server using mproxy #1918
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SammyOina
force-pushed
the
uv-267-coap
branch
2 times, most recently
from
be2a7a2 to
4a9b47c
Compare
SammyOina
force-pushed
the
uv-267-coap
branch
2 times, most recently
from
5c7f14b to
41af358
Compare
dborovcanin
force-pushed
the
uv-267-coap
branch
from
4d4a968 to
01e36fc
Compare
Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
The httpserver configuration in main.go was updated to use the targetCoAPServerCfg variable instead of the httpServerConfig variable. This change ensures that the correct configuration is used for the httpserver. Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
The bug was causing the client to acquire the message using the wrong context. This has been fixed by using the correct context.Background() method. Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
dborovcanin
force-pushed
the
uv-267-coap
branch
from
01e36fc to
46fe8ba
Compare
Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
The sendResp function in transport.go was missing a parameter 'isObs' which caused an error when trying to write the response message. This commit adds the 'isObs' parameter to the function signature and checks if it is false before writing the message. This fixes the bug and ensures that the response is only written when necessary. Signed-off-by: SammyOina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
cmd/coap/main.goto use a new target host and port.Publishmethod from theServiceinterface and its implementation incoap/adapter.go, simplifying the message handling process.Publishmethod incoap/api/logging.goandcoap/api/metrics.go.proxyCoAPfunction incmd/coap/main.gofor handling CoAP proxy operations.coap/handler.gofor managing client connections and disconnections, and handling authentication, publishing, and subscribing.Which issue(s) does this PR fix/relate to?
Resolves https://github.com/ultravioletrs/issues/issues/267
List any changes that modify/break current functionality
Have you included tests for your changes?
Did you document any new/modified functionality?
Notes