Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Homepage Setup #23

Merged
merged 22 commits into from
Sep 15, 2023
Merged

Homepage Setup #23

merged 22 commits into from
Sep 15, 2023

Conversation

angela139
Copy link
Contributor

  • Created folder structure for the components on the homepage
  • Added landing card/hero component with ACM Hack banner

@vercel
Copy link

vercel bot commented Sep 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hack-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 14, 2023 6:42pm

nishantbalaji
nishantbalaji requested changes Sep 7, 2023
View reviewed changes
Copy link
Member

@nishantbalaji nishantbalaji left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fire 🔥 🔥 let her cook

i have a few nits for u regarding design, i'll do a comprehensive review later :

  • can we make the navbar solid on just this page? or maybe minimize it so its not so large
  • the "ACM Hack" text shouldnt move up as the description is typed in, maybe make that appear downwards?
  • thoughts on implementing framer motion?

alexzhang1618
alexzhang1618 reviewed Sep 7, 2023
View reviewed changes
Copy link
Contributor

@alexzhang1618 alexzhang1618 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frontpage is looking 🔥! Some design comments:

  • the hero component is kinda orangey, are there thoughts on making the background match light/dark mode?
  • When you click on Hack School in the navbar, the items disappear from the navbar. Is this intended?
Screenshot 2023-09-06 at 7 39 37 PM

src/sections/Hero/index.tsx Outdated Show resolved Hide resolved
src/sections/Hero/style.module.css Outdated Show resolved Hide resolved
pages/index.mdx Outdated Show resolved Hide resolved
@nishantbalaji nishantbalaji mentioned this pull request Sep 13, 2023
Merged
nishantbalaji
nishantbalaji requested changes Sep 14, 2023
View reviewed changes
Copy link
Member

@nishantbalaji nishantbalaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks great! just one thing i noticed, and then we can ship:

i'm on a larger screen, so the diamonds cut off abruptly like this:
image

maybe we can include a lot of offscreen diamonds so ppl with large or ultrawide screens have content filling the space?

nishantbalaji
nishantbalaji approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@nishantbalaji nishantbalaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚀

@angela139 angela139 merged commit 2031ac0 into main Sep 15, 2023
3 checks passed
@angela139 angela139 deleted the angela/homepage-setup branch September 15, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexzhang1618 alexzhang1618 alexzhang1618 left review comments

@nishantbalaji nishantbalaji nishantbalaji approved these changes

@charvishukla charvishukla Awaiting requested review from charvishukla charvishukla is a code owner automatically assigned from acmucsd/acm-hack

Assignees

@angela139 angela139

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@angela139 @alexzhang1618 @nishantbalaji @avVergnet @AVERGNET