Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(geo): Gen3 portal links #3531

Merged
merged 101 commits into from
Aug 26, 2024
Merged

feat(geo): Gen3 portal links #3531

merged 101 commits into from
Aug 26, 2024

Conversation

paulgessinger
Copy link
Member

@paulgessinger paulgessinger commented Aug 21, 2024 •
edited
Loading

@paulgessinger paulgessinger added this to the next milestone Aug 21, 2024
@paulgessinger paulgessinger mentioned this pull request Aug 21, 2024
Open
@github-actions github-actions bot added the Component - Core Affects the Core module label Aug 21, 2024
andiwand
andiwand reviewed Aug 22, 2024
View reviewed changes
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

took a very very quick look

Core/include/Acts/Geometry/CompositePortalLink.hpp Outdated Show resolved Hide resolved
Core/include/Acts/Geometry/CompositePortalLink.hpp Outdated Show resolved Hide resolved
Core/include/Acts/Geometry/PortalLinkBase.hpp Outdated Show resolved Hide resolved
Tests/UnitTests/Core/Geometry/PortalLinkTests.cpp Outdated Show resolved Hide resolved
Core/src/Geometry/GridPortalLink.cpp Show resolved Hide resolved
@paulgessinger paulgessinger added the 🛑 blocked This item is blocked by another item label Aug 22, 2024
andiwand
andiwand previously approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments and questions but looks good to me overall!

Core/include/Acts/Geometry/CompositePortalLink.hpp Outdated Show resolved Hide resolved
Core/include/Acts/Geometry/CompositePortalLink.hpp Outdated Show resolved Hide resolved
Core/include/Acts/Geometry/CompositePortalLink.hpp Outdated Show resolved Hide resolved
Core/include/Acts/Geometry/CompositePortalLink.hpp Show resolved Hide resolved
Core/src/Geometry/CompositePortalLink.cpp Outdated Show resolved Hide resolved
Core/include/Acts/Geometry/GridPortalLink.hpp Outdated Show resolved Hide resolved
Core/include/Acts/Geometry/PortalLinkBase.hpp Outdated Show resolved Hide resolved
Core/src/Geometry/GridPortalLinkMerging.cpp Show resolved Hide resolved
Core/src/Geometry/GridPortalLinkMerging.cpp Show resolved Hide resolved
Core/src/Geometry/GridPortalLinkMerging.cpp Outdated Show resolved Hide resolved
andiwand
andiwand previously approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go from my side 👍

@kodiakhq kodiakhq bot merged commit 7735d2d into acts-project:main Aug 26, 2024
41 checks passed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 26, 2024

Quality Gate Passed Quality Gate passed

Issues
14 New issues
0 Accepted issues

Measures
0 Security Hotspots
34.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@acts-project-service
Copy link
Collaborator

🔴 Athena integration test results [7735d2d]

🔴 Some tests have failed!

Please investigate the pipeline!

status job report
🟢 report_pull_request
🟢 run_art_test: test_data18_13TeV_1000evt
🟢 run_art_test: test_ttbarPU40_reco
🟢 test_ActsDumpGeometryIdentifiers
🔴 test_ActsCheckObjectCountsCachedWorkflow
🔴 test_ActsCheckObjectCountsWorkflow
🟢 test_ActsEFTrackFit
🟢 test_ActsPersistifySeeds
🟢 test_ActsBenchmarkWithSpot
🟢 test_ActsAnalogueClustering
🔴 test_ActsWorkflowHeavyIons
🔴 test_ActsWorkflowFastTracking
🔴 test_ActsWorkflowCached
🔴 test_ActsWorkflow
🟢 test_ActsValidateAmbiguityResolution
🔴 test_ActsValidateResolvedTracks
🟢 test_ActsValidateTracks
🟢 test_ActsValidateActsCoreSpacePoints
🟢 test_ActsValidateActsSpacePoints
🟢 test_ActsValidateSeeds
🟢 test_ActsValidateOrthogonalSeeds
🟢 test_ActsValidateClusters
🔴 test_ActsPersistifyEDM
🟢 test_ActsGSFRefitting
🟢 test_ActsKfRefitting
🟢 test_ActsExtrapolationAlgTest
🟢 test_ActsITkTest
🟢 run_workflow_tests_run4_mc
🟢 run_workflow_tests_run2_mc
🟢 run_workflow_tests_run2_data
🟢 run_workflow_tests_run3_mc
🟢 run_workflow_tests_run3_data
🟢 run_unit_tests

@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Aug 26, 2024
@paulgessinger paulgessinger deleted the feat/gen3-portal-links branch August 27, 2024 06:46
@andiwand andiwand modified the milestones: next, v36.3.0 Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andiwand andiwand andiwand approved these changes

@asalzburger asalzburger Awaiting requested review from asalzburger

Assignees
No one assigned
Labels
Component - Core Affects the Core module Fails Athena tests This PR causes a failure in the Athena tests
Projects
None yet
Milestone
v36.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@paulgessinger @acts-project-service @andiwand