Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(geo): Gen3 portal links #3531

Merged
merged 101 commits into from
Aug 26, 2024
Merged

feat(geo): Gen3 portal links #3531

merged 101 commits into from
Aug 26, 2024

Commits on Aug 21, 2024

  1. feat(geo): TrackingGeometry setVolumeName method

    @paulgessinger
    paulgessinger committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    1de1182 View commit details
    Browse the repository at this point in the history

  2. feat(geo): TrackingVolume move constructor

    @paulgessinger
    paulgessinger committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    44e5903 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. feat(geo): Surface::isOnSurface gets tolerance parameter

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    c371fb7 View commit details
    Browse the repository at this point in the history

  2. Portal stitching exploration

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    3db513d View commit details
    Browse the repository at this point in the history

  3. checkpoint w/o double-dispatch

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    ba11b51 View commit details
    Browse the repository at this point in the history

  4. portal: more portal merging exploration

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    13f1041 View commit details
    Browse the repository at this point in the history

  5. fixes after axis refactor

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    3d39501 View commit details
    Browse the repository at this point in the history

  6. wip

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    f81860b View commit details
    Browse the repository at this point in the history

  7. fix axistype tags

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    b7e1899 View commit details
    Browse the repository at this point in the history

  8. portal testing

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    7c5cf1f View commit details
    Browse the repository at this point in the history

  9. fix format

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    0db5fff View commit details
    Browse the repository at this point in the history

  10. wip

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    9d1466e View commit details
    Browse the repository at this point in the history

  11. wip2

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    47ec05e View commit details
    Browse the repository at this point in the history

  12. wip

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    52dd26c View commit details
    Browse the repository at this point in the history

  13. wip

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    8ecf99b View commit details
    Browse the repository at this point in the history

  14. some colinear merging works

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    b430a4d View commit details
    Browse the repository at this point in the history

  15. some progress, i'm realizing i need to think more about phi stitching

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    12558c4 View commit details
    Browse the repository at this point in the history

  16. wip

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    56d568e View commit details
    Browse the repository at this point in the history

  17. remove gctx

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    22d40b1 View commit details
    Browse the repository at this point in the history

  18. wip

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    6ad4bad View commit details
    Browse the repository at this point in the history

  19. updates after BinningValue change

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    d15e350 View commit details
    Browse the repository at this point in the history

  20. wip

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    7e2b729 View commit details
    Browse the repository at this point in the history

  21. remove gctx, test more of the phi merging

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    bbe69d3 View commit details
    Browse the repository at this point in the history

  22. 1d cylinder merging sort of works

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    8197ef9 View commit details
    Browse the repository at this point in the history

  23. unify axis creation a bit more

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    9b20720 View commit details
    Browse the repository at this point in the history

  24. first attempt at 2D grid merging (might need some refactoring)

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    6bfb5e0 View commit details
    Browse the repository at this point in the history

  25. expand 1D grid to 2D in preparation for further merging

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    425cee3 View commit details
    Browse the repository at this point in the history

  26. fix 2d portal merge memory error, complete tests

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    e5fa9da View commit details
    Browse the repository at this point in the history

  27. wip

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    56d41c3 View commit details
    Browse the repository at this point in the history

  28. towards full 2D and perpendicular merging

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    8cf0803 View commit details
    Browse the repository at this point in the history

  29. perpendicular cylinder merge works

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    aca5823 View commit details
    Browse the repository at this point in the history

  30. remove direction from template arguments (can be runtime)

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    1496445 View commit details
    Browse the repository at this point in the history

  31. fix format

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    513fbc8 View commit details
    Browse the repository at this point in the history

  32. begin work on disc surfaces

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    04368a3 View commit details
    Browse the repository at this point in the history

  33. start adding disc tests

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    d1356d3 View commit details
    Browse the repository at this point in the history

  34. first disc portal construction tests and shuffling of impl. code

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    eea71fd View commit details
    Browse the repository at this point in the history

  35. fix format

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    09af2ba View commit details
    Browse the repository at this point in the history

  36. tested disc merging

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    fddc9de View commit details
    Browse the repository at this point in the history

  37. rename 'perpendicular' case to 'parallel'

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    c5d82dd View commit details
    Browse the repository at this point in the history

  38. support mixed merging

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    6011438 View commit details
    Browse the repository at this point in the history

  39. portallinks keep a mutable shared ptr for the surface

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    9dc9429 View commit details
    Browse the repository at this point in the history

  40. split portal types up, start implementing conversion

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    24d71ad View commit details
    Browse the repository at this point in the history

  41. 1d to 2d extension in principle works with existing axes now

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    ab40d48 View commit details
    Browse the repository at this point in the history

  42. mixed merging carries over other axis

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    cfbf8fd View commit details
    Browse the repository at this point in the history

  43. grid portal filling tested for 2D 

    still need to test 1d, but should work the same
    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    d6e222e View commit details
    Browse the repository at this point in the history

  44. fix format

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    3cb3e70 View commit details
    Browse the repository at this point in the history

  45. cross merging works including bin contents

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    79bd1bd View commit details
    Browse the repository at this point in the history

  46. split up grid merging and rest of .cpp, push content printer to cpp

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    712d514 View commit details
    Browse the repository at this point in the history

  47. reduce verbosity a bit

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    830fa3d View commit details
    Browse the repository at this point in the history

  48. some more bin filling testing

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    b83a0ca View commit details
    Browse the repository at this point in the history

  49. grid construction from trivial working for discs

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    159695d View commit details
    Browse the repository at this point in the history

  50. reduce likelihood of surface confusion, fix tests

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    30f0a5f View commit details
    Browse the repository at this point in the history

  51. fix a few more cases or order-dependent bin edges

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    e4b390a View commit details
    Browse the repository at this point in the history

  52. migrate merging model away from double dispatch 

    we need to have the option to take ownership for composites, so can't do
double dispatch without shared-from-this, which I want to avoid.
    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    c937fc5 View commit details
    Browse the repository at this point in the history

  53. avoid one roundtrip method call

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    d69ee07 View commit details
    Browse the repository at this point in the history

  54. composite construction including basic flattening

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    8284dca View commit details
    Browse the repository at this point in the history

  55. composite by merging basically works

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    da3c638 View commit details
    Browse the repository at this point in the history

  56. optimize memory usage at build-time

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    b0d0224 View commit details
    Browse the repository at this point in the history

  57. enable composite fallback for grid merging

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    b5b1b72 View commit details
    Browse the repository at this point in the history

  58. accept mutable portal links so we can store them mutably in composite 

    this is needed if we want to be able to mutate them through mutable
owning paths
    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    5da341d View commit details
    Browse the repository at this point in the history

  59. fixes after dropping operator<< on Surface

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    952c6e0 View commit details
    Browse the repository at this point in the history

  60. remove unneeded code

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    9418092 View commit details
    Browse the repository at this point in the history

  61. internal storage of volumes becomes mutable 

    this is so we can reassign volumes later on
we need to be careful that this doesn't leak out however
    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    23af824 View commit details
    Browse the repository at this point in the history

  62. remove unneeded friend declarations

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    d121c5a View commit details
    Browse the repository at this point in the history

  63. cleanup

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    a4bb5da View commit details
    Browse the repository at this point in the history

  64. split up portallink tests and portal tests

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    a14bccf View commit details
    Browse the repository at this point in the history

  65. link: grid axes are allowed to be open

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    8708d48 View commit details
    Browse the repository at this point in the history

  66. link: resolveVolume interface, portal construction

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    46a4107 View commit details
    Browse the repository at this point in the history

  67. link: fix: projection from 2D to 1D in grid was missing

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    32bfffc View commit details
    Browse the repository at this point in the history

  68. link: refactor memory model, more testing of fusing, and error cases

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    890b7da View commit details
    Browse the repository at this point in the history

  69. link: TrivialPortalLink assertion for isOnSurface

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    b44bc5e View commit details
    Browse the repository at this point in the history

  70. link: GridPortalLink graphical doc comment

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    3e39aa0 View commit details
    Browse the repository at this point in the history

  71. link: PortalLinkBase is standalone file

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    07b0841 View commit details
    Browse the repository at this point in the history

  72. revert: Portal

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    4303407 View commit details
    Browse the repository at this point in the history

  73. link: surfacePtr returns by reference

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    6b36646 View commit details
    Browse the repository at this point in the history

  74. link: PR feedback

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    65ca8a7 View commit details
    Browse the repository at this point in the history

  75. link: Remove Portal.hpp include

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    cd7addf View commit details
    Browse the repository at this point in the history

  76. link: Pipe through tolerance in resolveVolume

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    c717c73 View commit details
    Browse the repository at this point in the history

  77. link: Remove visitBins in GridPortalLink

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    2a6bf95 View commit details
    Browse the repository at this point in the history

  78. link: Add documentation to method

    @paulgessinger
    paulgessinger committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    dfc4b31 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. link: resolveVolume returns Result

    @paulgessinger
    paulgessinger committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    b8c7a4e View commit details
    Browse the repository at this point in the history

  2. link: un-document unused parameters

    @paulgessinger
    paulgessinger committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    247306a View commit details
    Browse the repository at this point in the history

  3. link: Fix unit tests after converting from exception to assertions 

    (we can't test this anymore)
    @paulgessinger
    paulgessinger committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    36ba8a6 View commit details
    Browse the repository at this point in the history

  4. fix(util): IAxis::visit ensures return 

    This was not caught because the unit test does not test return types
    @paulgessinger
    paulgessinger committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    d7f93d0 View commit details
    Browse the repository at this point in the history

  5. link: Lint fixes

    @paulgessinger
    paulgessinger committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    5696d1a View commit details
    Browse the repository at this point in the history

  6. link: move TrivialPortalLink::toStream to cpp file

    @paulgessinger
    paulgessinger committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    3a57523 View commit details
    Browse the repository at this point in the history

  7. link: work around std::format not being available

    @paulgessinger
    paulgessinger committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    fb072b9 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Merge branch 'main' into feat/gen3-portal-links

    @paulgessinger
    paulgessinger authored Aug 26, 2024
    Configuration menu
    Copy the full SHA
    779c5ee View commit details
    Browse the repository at this point in the history

  2. link: remove extra constructor

    @paulgessinger
    paulgessinger committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    2065f34 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Andreas Stefl <[email protected]>
    @paulgessinger @andiwand
    paulgessinger and andiwand authored Aug 26, 2024
    Configuration menu
    Copy the full SHA
    5d02f8d View commit details
    Browse the repository at this point in the history

  4. link: add portal error for composite case

    @paulgessinger
    paulgessinger committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    1ba08e1 View commit details
    Browse the repository at this point in the history

  5. link: Make PortalLinkBase constructor explicit

    @paulgessinger
    paulgessinger committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    548df85 View commit details
    Browse the repository at this point in the history

  6. link: improve grid extension method name

    @paulgessinger
    paulgessinger committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    1b43cb9 View commit details
    Browse the repository at this point in the history

  7. link: Remove funky else case assertion

    @paulgessinger
    paulgessinger committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    bf638df View commit details
    Browse the repository at this point in the history

  8. link: doc / comment updates

    @paulgessinger
    paulgessinger committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    9f713c5 View commit details
    Browse the repository at this point in the history

  9. link: don't use std::format at all

    @paulgessinger
    paulgessinger committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    280e084 View commit details
    Browse the repository at this point in the history

  10. link: make sonar happier

    @paulgessinger
    paulgessinger committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    13a585d View commit details
    Browse the repository at this point in the history

  11. link: fix shadowed variable, remove explicit captures again

    @paulgessinger
    paulgessinger committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    d8b9b3d View commit details
    Browse the repository at this point in the history

  12. link: Add explicit check for non-null surface

    @paulgessinger
    paulgessinger committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    4a95288 View commit details
    Browse the repository at this point in the history

  13. Merge branch 'main' into feat/gen3-portal-links

    @kodiakhq
    kodiakhq[bot] authored Aug 26, 2024
    Configuration menu
    Copy the full SHA
    70a3e83 View commit details
    Browse the repository at this point in the history

  14. Merge branch 'main' into feat/gen3-portal-links

    @kodiakhq
    kodiakhq[bot] authored Aug 26, 2024
    Configuration menu
    Copy the full SHA
    ec1c1db View commit details
    Browse the repository at this point in the history