fix(geo): CylVolStack reuses gaps if exist #3716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to pass it through if you have one (CylinderVolumeStack mainly)
This fixes a bug where the local transform was not correctly synced after resizing. Also improves a number of assertions to not rely on floating point identity anymore
Open
andiwand
previously approved these changes
Oct 11, 2024
paulgessinger
force-pushed
the
feat/cyl-vol-stack-gap-reuse
branch
from
f62da4f
to
b11a2a2
Compare
|
I realized this actually needs #3715 |
paulgessinger
force-pushed
the
feat/cyl-vol-stack-gap-reuse
branch
from
b11a2a2
to
8b0788b
Compare
|
|
This is now unblocked and green! |
andiwand
approved these changes
Oct 12, 2024
Rosie-Hasan
pushed a commit
to Rosie-Hasan/acts
that referenced
this pull request
Nov 13, 2024
This PR makes it such that when a `CylinderVolumeStack` is resized with the gap strategy, if there are already gaps on the outside of the stack, **they are reused** instead of creating extra gaps. Part of to acts-project#3502. ``` original size ◀───────────────▶ ┌───────────────┐ │ │ │ │ │ Volume 1 │ │ │ │ │ └───────────────┘ first resize ◀──────────────────────────▶ ┌───────────────┬──────────┐ │ │ │ │ │ │ │ Volume 1 │ Gap │ │ │ │ Gap is │ │ │ reused!──┐ └───────────────┴──────────┘ │ second resize │ ◀───────────────────────────────────▶ │ ┌───────────────┬───────────────────┐ │ │ │ │ │ │ │ │ │ │ Volume 1 │ Gap │◀─────┘ │ │ │ │ │ │ └───────────────┴───────────────────┘ ``` Blocked by: - acts-project#3715
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it such that when a
CylinderVolumeStackis resized with the gap strategy, if there are already gaps on the outside of the stack, they are reused instead of creating extra gaps.Part of to #3502.
Blocked by: