-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(geo): CylVolStack reuses gaps if exist #3716
Merged
paulgessinger
merged 10 commits into
acts-project:main
from
paulgessinger:feat/cyl-vol-stack-gap-reuse
Oct 12, 2024
Merged
fix(geo): CylVolStack reuses gaps if exist #3716
paulgessinger
merged 10 commits into
acts-project:main
from
paulgessinger:feat/cyl-vol-stack-gap-reuse
Oct 12, 2024
Commits on Oct 11, 2024
-
refactor: Add logger to Volume::update
This makes it easier to pass it through if you have one (CylinderVolumeStack mainly)
Configuration menu - View commit details
-
Copy full SHA for da0d486 - Browse repository at this point
Copy the full SHA da0d486View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5bd91eb - Browse repository at this point
Copy the full SHA 5bd91ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 88aaf5a - Browse repository at this point
Copy the full SHA 88aaf5aView commit details -
fix: CylVolStack resizing issue
This fixes a bug where the local transform was not correctly synced after resizing. Also improves a number of assertions to not rely on floating point identity anymore
Configuration menu - View commit details
-
Copy full SHA for d57fc22 - Browse repository at this point
Copy the full SHA d57fc22View commit details -
Configuration menu - View commit details
-
Copy full SHA for ddb4d46 - Browse repository at this point
Copy the full SHA ddb4d46View commit details -
Configuration menu - View commit details
-
Copy full SHA for b1703d6 - Browse repository at this point
Copy the full SHA b1703d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 15241bb - Browse repository at this point
Copy the full SHA 15241bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c2b92b - Browse repository at this point
Copy the full SHA 9c2b92bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d1d8361 - Browse repository at this point
Copy the full SHA d1d8361View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b0788b - Browse repository at this point
Copy the full SHA 8b0788bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.