Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace updateFirst by update & Wait for full data image in order to display it #25

Merged
merged 2 commits into from
May 26, 2018

Conversation

Zombitch
Copy link

Pull request description :

2 commits :

  • According to this FFMpeg patch updateFirst option has been remove because of it was a duplicate of update option. I replace updateFirst by replace in the code.
  • Second commit is about consolidating chunk data in order to get a full image. In some case, the stream data doesn't send a full image but a part of an image. With this new code, the system wait and concat data until it found EOI (end of image) marker from the data. When EOI is found, then data is sent; this way we always get a full image.

Fix issues

This pull request aims on resolving these issues :

And also maybe those related issue in connection with the "corrupted images" topic :

Tests

Human tests have been done sucessfully on both debian and windows 10 OS.

Zombitch added 2 commits May 25, 2018 21:11
…ng an image that can be a chunk of the full image in some case
@agsh agsh merged commit f17ffbf into agsh:master May 26, 2018
@agsh
Copy link
Owner

agsh commented May 26, 2018

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants