-
Notifications
You must be signed in to change notification settings - Fork 55
Update to Faraday 1.0 #28
base: master
Are you sure you want to change the base?
Update to Faraday 1.0 #28
Conversation
* Drop support Ruby <= 2.4 because their statuses are EOL. * Add support Ruby 2.5, 2.6, 2.7
Because json-1.8.x gem produces a deprecation warning on Ruby 2.7. see: ruby/json#399
My project also requires faraday > 1.0. Any chance this could get a version cut? |
Dear @airbnb developers! Sorry for the shout, but this PR has been waiting for over a year without any answer. It will be nice of you if something moves on this matter. If you need help, let me know too. Thank you in advance. |
up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This comment was marked as spam.
This comment was marked as spam.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't if I should approve this? (they asked me to do that) but okay :))
This comment was marked as spam.
This comment was marked as spam.
Spam PR approvals from non-maintainers will decrease, not increase, the PR's chances of being landed. (cc @henriquesml) |
@ljharb You are right, it's not a commendable behavior. I'm concerned that this project has been abandoned, even though many people are still using it. Lack of any information from the owners is perhaps the worst possible thing. What can we do to help? |
I doubt there’s anything to be done but wait patiently. |
LGTM, let's go for merge! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, this project is stuck in time and we need this change
As the PR #27 I sent a before, Migrating Faraday to 1.x has significant changes.
So, I suggest to update the old dependencies and the supported Ruby versions in order to meet the recent development circumstances.
I think this gem is great, but it blocks updating the other gems which dependent to Faraday in my projects.
This change needs a major update, would you consider it?
ref: https://github.com/lostisland/faraday/blob/master/UPGRADING.md