Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Update to Faraday 1.0 #28

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

9toon
Copy link

@9toon 9toon commented Feb 28, 2021

As the PR #27 I sent a before, Migrating Faraday to 1.x has significant changes.
So, I suggest to update the old dependencies and the supported Ruby versions in order to meet the recent development circumstances.

I think this gem is great, but it blocks updating the other gems which dependent to Faraday in my projects.

This change needs a major update, would you consider it?

ref: https://github.com/lostisland/faraday/blob/master/UPGRADING.md

@ehlertij
Copy link

My project also requires faraday > 1.0. Any chance this could get a version cut?

@torrocus
Copy link

torrocus commented Jul 6, 2022

Dear @airbnb developers!
Is there a slim chance that this PR will be merged anytime soon? Since it is difficult to determine who of the contributors is still working in AirBnb, I mention a few people.
@goatslacker @100 @a15n @indiesquidge @keeleysam @lencioni @tobymao

Sorry for the shout, but this PR has been waiting for over a year without any answer. It will be nice of you if something moves on this matter. If you need help, let me know too. Thank you in advance.

@henriquesml
Copy link

image

@voigtito
Copy link

up

Copy link

@pedroida pedroida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jvitormichels

This comment was marked as spam.

Copy link

@LuizKraisch LuizKraisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't if I should approve this? (they asked me to do that) but okay :))

@erik-tomelin

This comment was marked as spam.

@ljharb
Copy link
Collaborator

ljharb commented Aug 12, 2022

Spam PR approvals from non-maintainers will decrease, not increase, the PR's chances of being landed. (cc @henriquesml)

@torrocus
Copy link

Spam PR approvals from non-maintainers will decrease, not increase, the PR's chances of being landed. (cc @henriquesml)

@ljharb You are right, it's not a commendable behavior. I'm concerned that this project has been abandoned, even though many people are still using it. Lack of any information from the owners is perhaps the worst possible thing. What can we do to help?

@ljharb
Copy link
Collaborator

ljharb commented Aug 15, 2022

I doubt there’s anything to be done but wait patiently.

@torrocus
Copy link

torrocus commented Sep 7, 2022

I doubt there’s anything to be done but wait patiently.

@ljharb May I kindly ask what amount of patience is needed for some @airbnb developer to merge these changes? I would like to point out that this is over a year and a half. This project looks abandoned.

@diclophis
Copy link

LGTM, let's go for merge!

Copy link

@RuiPMoreira RuiPMoreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, this project is stuck in time and we need this change

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.