Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Update to Faraday 1.0 #28

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,9 @@ language: ruby
sudo: false
cache: bundler
rvm:
- "1.9.3"
- "2.0"
- "2.1"
- "2.2"
- "2.3.3"
- "2.5"
- "2.6"
- "2.7"
before_install:
- gem update bundler
script:
Expand Down
12 changes: 3 additions & 9 deletions hypernova.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -33,18 +33,12 @@ Gem::Specification.new do |spec|
spec.metadata["allowed_push_host"] = 'https://rubygems.org'
end

spec.add_development_dependency "json", "~> 1.8"
spec.add_development_dependency "json"
spec.add_development_dependency "rake", "~> 10.0"
spec.add_development_dependency "rspec", "~> 3.4"
spec.add_development_dependency "simplecov", "~> 0.11"
spec.add_development_dependency "pry", "~> 0.10"
# this is pinned because ruby devs hate semver
# see https://github.com/bblimke/webmock/issues/667
spec.add_development_dependency "webmock", "=2.1.0"
# below works around travis-ci requiring github-pages-health-check, whose subdep public_suffix
# stopped being compatible with ruby 1.9
# see https://github.com/weppos/publicsuffix-ruby/issues/127
spec.add_development_dependency "public_suffix", "=1.4.6"
spec.add_development_dependency "webmock", "~> 3.0"

spec.add_runtime_dependency "faraday", "~> 0.8"
spec.add_runtime_dependency "faraday", "~> 1"
end
2 changes: 1 addition & 1 deletion spec/faraday_connection_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
}).
and_call_original

expect(described_class.build.builder.handlers).to include(Faraday::Adapter::NetHttp)
expect(described_class.build.builder.adapter).to eq(Faraday::Adapter::NetHttp)
end
end
end