Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cotextmenu cropped #4682

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

YueyingLu
Copy link

Issue #4681, if available:

Description of changes:
Problem to solve: ContextMenu gets cropped on small mobile screen sizes or with larger the font size. In addition, buttons needs more distance to distinguish separate ones. In the screenshot, it is hard to tell that "Select All" is one button and "Paste" is the next button. Screenshot can be reproduced on demo page with font size 24.
Screenshot 2022-04-27 at 15 19 35

Solution: Buttons display block.
Check if menu gets cropped at bottom. If so opens the menu up(by moving the menu up). When close menu by clicking the "more" button, move menu icon back to the cursor position.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #4682 (7cc0c2a) into master (6bf0d68) will increase coverage by 0.00%.
The diff coverage is 37.50%.

@@           Coverage Diff           @@
##           master    #4682   +/-   ##
=======================================
  Coverage   71.17%   71.18%           
=======================================
  Files         553      553           
  Lines       55572    55593   +21     
  Branches    10398    10394    -4     
=======================================
+ Hits        39555    39575   +20     
- Misses      16017    16018    +1     
Flag Coverage Δ
unittests 71.18% <37.50%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/ace/mouse/touch_handler.js 87.86% <37.50%> (-1.75%) ⬇️
lib/ace/editor.js 79.71% <0.00%> (-1.91%) ⬇️
lib/ace/mode/php_laravel_blade_highlight_rules.js 100.00% <0.00%> (ø)
lib/ace/virtual_renderer.js 80.00% <0.00%> (+0.11%) ⬆️
lib/ace/edit_session/folding.js 75.37% <0.00%> (+0.93%) ⬆️
lib/ace/mouse/mouse_handler_test.js 99.51% <0.00%> (+1.15%) ⬆️
lib/ace/lib/event.js 72.94% <0.00%> (+9.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bf0d68...7cc0c2a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants