-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic(ms-basic) highlight mode #5649
Conversation
Old school |
@whazor should we disable |
We don't need to support old IE anymore. However, it would be ironic to disable old IE support in order to support an even older Microsoft technology. |
Could you also add the new modes to |
One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5649 +/- ##
========================================
Coverage 87.00% 87.01%
========================================
Files 594 598 +4
Lines 43516 43665 +149
Branches 7174 7205 +31
========================================
+ Hits 37862 37994 +132
- Misses 5654 5671 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Issue #, if available: #5550
Description of changes:
Add token highlighting and folding for basic language. MS-BASIC was taken as basis, because seems it was the most popular one in times
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Pull Request Checklist:
ace.d.ts
) and its references: