Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic(ms-basic) highlight mode #5649

Merged
merged 4 commits into from
Oct 21, 2024

Conversation

mkslanc
Copy link
Contributor

@mkslanc mkslanc commented Sep 29, 2024

Issue #, if available: #5550

Description of changes:
Add token highlighting and folding for basic language. MS-BASIC was taken as basis, because seems it was the most popular one in times

image

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

@whazor
Copy link
Contributor

whazor commented Oct 7, 2024

Old school

@nightwing
Copy link
Member

@whazor should we disable error Unexpected trailing comma comma-dangle eslint rule? we had added it for old IE, but new browsers all support trailing commas.

@whazor
Copy link
Contributor

whazor commented Oct 16, 2024

We don't need to support old IE anymore. However, it would be ironic to disable old IE support in order to support an even older Microsoft technology.

@akoreman
Copy link
Contributor

Could you also add the new modes to ace-modes.d.ts to resolve the failing build

Copy link

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 88.59060% with 17 lines in your changes missing coverage. Please review.

Project coverage is 87.01%. Comparing base (b168a97) to head (a511312).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/mode/basic.js 57.69% 11 Missing ⚠️
src/mode/folding/basic.js 93.05% 5 Missing ⚠️
src/mode/folding/basic_test.js 97.67% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #5649    +/-   ##
========================================
  Coverage   87.00%   87.01%            
========================================
  Files         594      598     +4     
  Lines       43516    43665   +149     
  Branches     7174     7205    +31     
========================================
+ Hits        37862    37994   +132     
- Misses       5654     5671    +17     
Flag Coverage Δ
unittests 87.01% <88.59%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nightwing nightwing merged commit 31cb7b5 into ajaxorg:master Oct 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants