Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: keep track of promotion state in promotion status #2604

Merged
merged 6 commits into from
Sep 30, 2024

make wait-for-pr tolerate a float64 pr number

dab7545
Select commit
Loading
Failed to load commit list.
Merged

feat: keep track of promotion state in promotion status #2604

make wait-for-pr tolerate a float64 pr number
dab7545
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Sep 29, 2024 in 0s

26.37% of diff hit (target 51.09%)

View this Pull Request on Codecov

26.37% of diff hit (target 51.09%)

Annotations

Check warning on line 158 in api/v1alpha1/promotion_types.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/v1alpha1/promotion_types.go#L156-L158 

Added lines #L156 - L158 were not covered by tests

Check warning on line 163 in api/v1alpha1/promotion_types.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/v1alpha1/promotion_types.go#L161-L163 

Added lines #L161 - L163 were not covered by tests

Check warning on line 165 in api/v1alpha1/promotion_types.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/v1alpha1/promotion_types.go#L165 

Added line #L165 was not covered by tests

Check warning on line 521 in internal/controller/promotions/promotions.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/controller/promotions/promotions.go#L514-L521 

Added lines #L514 - L521 were not covered by tests

Check warning on line 523 in internal/controller/promotions/promotions.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/controller/promotions/promotions.go#L523 

Added line #L523 was not covered by tests

Check warning on line 528 in internal/controller/promotions/promotions.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/controller/promotions/promotions.go#L526-L528 

Added lines #L526 - L528 were not covered by tests

Check warning on line 533 in internal/controller/promotions/promotions.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/controller/promotions/promotions.go#L533 

Added line #L533 was not covered by tests

Check warning on line 541 in internal/controller/promotions/promotions.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/controller/promotions/promotions.go#L539-L541 

Added lines #L539 - L541 were not covered by tests

Check warning on line 142 in internal/directives/git_pr_waiter.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/directives/git_pr_waiter.go#L137-L142 

Added lines #L137 - L142 were not covered by tests

Check warning on line 149 in internal/directives/git_pr_waiter.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/directives/git_pr_waiter.go#L144-L149 

Added lines #L144 - L149 were not covered by tests

Check warning on line 156 in internal/directives/git_pr_waiter.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/directives/git_pr_waiter.go#L151-L156 

Added lines #L151 - L156 were not covered by tests

Check warning on line 170 in internal/directives/git_pr_waiter.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/directives/git_pr_waiter.go#L161-L170 

Added lines #L161 - L170 were not covered by tests

Check warning on line 54 in internal/directives/simple_engine.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/directives/simple_engine.go#L51-L54 

Added lines #L51 - L54 were not covered by tests

Check warning on line 113 in internal/directives/simple_engine.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/directives/simple_engine.go#L113 

Added line #L113 was not covered by tests

Check warning on line 129 in internal/directives/simple_engine.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/directives/simple_engine.go#L125-L129 

Added lines #L125 - L129 were not covered by tests

Check warning on line 39 in internal/directives/state.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/directives/state.go#L37-L39 

Added lines #L37 - L39 were not covered by tests

Check warning on line 42 in internal/directives/state.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/directives/state.go#L41-L42 

Added lines #L41 - L42 were not covered by tests
View more details on Codecov