Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(indexer): extract Apps from Promotion directives #2620

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

hiddeco
Copy link
Contributor

@hiddeco hiddeco commented Oct 1, 2024

Variation of #2593.

As noted in the // TODO, I would like at some point for us to not treat certain directives as "special" — but from a functional point of view, that's not a strict requirement at this point.

I did have to move the indexers out of kubeclient, to get around a cyclic import.

Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit 6f38edf
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/66fc50e78cd2140008a2b3b6
😎 Deploy Preview https://deploy-preview-2620.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hiddeco hiddeco force-pushed the fix-promotion-app-indexer branch 3 times, most recently from b42b05b to b5d2d1c Compare October 1, 2024 19:41
@hiddeco hiddeco changed the title chore: move indexers into dedicated module fix(indexer): extract Apps from Promotion directives Oct 1, 2024
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 46.47887% with 38 lines in your changes missing coverage. Please review.

Project coverage is 50.98%. Comparing base (0e79db7) to head (6f38edf).

Files with missing lines Patch % Lines
internal/indexer/indexer.go 50.00% 11 Missing and 1 partial ⚠️
internal/controller/stages/stages.go 61.90% 8 Missing ⚠️
internal/api/kubernetes/client.go 0.00% 6 Missing ⚠️
cmd/controlplane/garbage_collector.go 0.00% 3 Missing ⚠️
internal/controller/stages/watches.go 0.00% 3 Missing ⚠️
internal/api/option/auth.go 0.00% 2 Missing ⚠️
cmd/controlplane/webhooks.go 0.00% 1 Missing ⚠️
internal/api/list_project_events_v1alpha1.go 0.00% 1 Missing ⚠️
internal/api/list_promotions_v1alpha1.go 0.00% 1 Missing ⚠️
internal/controller/promotions/promotions.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2620      +/-   ##
==========================================
- Coverage   50.98%   50.98%   -0.01%     
==========================================
  Files         282      282              
  Lines       21015    21039      +24     
==========================================
+ Hits        10714    10726      +12     
- Misses       9630     9641      +11     
- Partials      671      672       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour krancour added this to the v0.9.0 milestone Oct 1, 2024
@hiddeco hiddeco added this pull request to the merge queue Oct 1, 2024
Merged via the queue into akuity:main with commit 806fa9f Oct 1, 2024
16 of 18 checks passed
@hiddeco hiddeco deleted the fix-promotion-app-indexer branch October 1, 2024 20:06
github-actions bot pushed a commit that referenced this pull request Oct 1, 2024
Signed-off-by: Hidde Beydals <[email protected]>
(cherry picked from commit 806fa9f)
@akuitybot
Copy link

Successfully created backport PR for release-0.9:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants