-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(indexer): extract Apps from Promotion directives #2620
Merged
Merged
+183
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hiddeco
force-pushed
the
fix-promotion-app-indexer
branch
3 times, most recently
from
October 1, 2024 19:41
b42b05b
to
b5d2d1c
Compare
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
hiddeco
force-pushed
the
fix-promotion-app-indexer
branch
from
October 1, 2024 19:43
b5d2d1c
to
6f38edf
Compare
hiddeco
changed the title
chore: move indexers into dedicated module
fix(indexer): extract Apps from Promotion directives
Oct 1, 2024
krancour
approved these changes
Oct 1, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2620 +/- ##
==========================================
- Coverage 50.98% 50.98% -0.01%
==========================================
Files 282 282
Lines 21015 21039 +24
==========================================
+ Hits 10714 10726 +12
- Misses 9630 9641 +11
- Partials 671 672 +1 ☔ View full report in Codecov by Sentry. |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 1, 2024
Signed-off-by: Hidde Beydals <[email protected]> (cherry picked from commit 806fa9f)
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variation of #2593.
As noted in the
// TODO
, I would like at some point for us to not treat certain directives as "special" — but from a functional point of view, that's not a strict requirement at this point.I did have to move the indexers out of
kubeclient
, to get around a cyclic import.