Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(backport release-0.9): fix(indexer): extract Apps from Promotion directives #2621

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

akuitybot
Copy link

Automated backport to release-0.9, triggered by a label in #2620.

Signed-off-by: Hidde Beydals <[email protected]>
(cherry picked from commit 806fa9f)
@hiddeco hiddeco enabled auto-merge (squash) October 1, 2024 20:12
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 46.47887% with 38 lines in your changes missing coverage. Please review.

Project coverage is 50.97%. Comparing base (a1d0a4c) to head (504d3a8).
Report is 1 commits behind head on release-0.9.

Files with missing lines Patch % Lines
internal/indexer/indexer.go 50.00% 11 Missing and 1 partial ⚠️
internal/controller/stages/stages.go 61.90% 8 Missing ⚠️
internal/api/kubernetes/client.go 0.00% 6 Missing ⚠️
cmd/controlplane/garbage_collector.go 0.00% 3 Missing ⚠️
internal/controller/stages/watches.go 0.00% 3 Missing ⚠️
internal/api/option/auth.go 0.00% 2 Missing ⚠️
cmd/controlplane/webhooks.go 0.00% 1 Missing ⚠️
internal/api/list_project_events_v1alpha1.go 0.00% 1 Missing ⚠️
internal/api/list_promotions_v1alpha1.go 0.00% 1 Missing ⚠️
internal/controller/promotions/promotions.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-0.9    #2621      +/-   ##
===============================================
- Coverage        50.97%   50.97%   -0.01%     
===============================================
  Files              283      283              
  Lines            21064    21088      +24     
===============================================
+ Hits             10737    10749      +12     
- Misses            9653     9664      +11     
- Partials           674      675       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hiddeco hiddeco merged commit 61ff2d3 into release-0.9 Oct 1, 2024
17 of 19 checks passed
@hiddeco hiddeco deleted the backport-2620-to-release-0.9 branch October 1, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants