Fix types and CI, refactor GHA workflow #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes make it easier to run type checks in a local development environment.
As `install` is a phony target, it is executed every time I run the tests, type checks etc. which slows things down unnecessarily.
… to ensure consistent processes during development and in CI.
tillprochaska
changed the title
stchris
approved these changes
Dec 14, 2023
|
Wait!!! Don't merge... oh you already did. LGTM2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a few miscellaneous changes related to type checking and CI.
setuptoolsnow needs to be installed explicitly in GHA runners, this is the same issue we had in other repositories before.I’ve added a new make target for type checking and changed the GHA workflow to run make instead of running pytest/mypy/setuptools etc. directly in order to ensure that the exact commands we run in development and in CI are consistent.
Fixed the minor type issues introduced in Add cleaned option #48 (didn’t spot them during review, my bad).