Fix types and CI, refactor GHA workflow

.github/workflows/build.yml

@@ -18,17 +18,14 @@ jobs:
       env:
         DEBIAN_FRONTEND: noninteractive
       run: |
-        pip install -e '.[dev]'
+        pip install setuptools
+        make install
     - name: Run the tests
-      run: pytest
-    - name: Install types
-      run: python -m pip install types-requests types-setuptools
+      run: make test
     - name: Validate typing
-      run: |
-        mypy .
+      run: make typecheck
     - name: Build a distribution
-      run: |
-        python setup.py sdist bdist_wheel
+      run: make dists
     - name: Publish a Python distribution to PyPI
       if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags')
       uses: pypa/gh-action-pypi-publish@master

Makefile

@@ -4,10 +4,13 @@ all: clean test dists
 install:
 	pip install -q -e ".[dev]"
 
-test: install
+test:
 	pytest
 
-dists: install
+typecheck:
+	mypy alephclient/	
+
+dists:
 	python setup.py sdist
 	python setup.py bdist_wheel
 

alephclient/api.py

@@ -343,9 +343,9 @@ def _bulk_chunk(
             url = self._make_url(f"collections/{collection_id}/_bulk")
             params = {"entityset_id": entityset_id}
             if unsafe:
-                params['safe'] = not unsafe
+                params["safe"] = "false"
             if cleaned:
-                params['clean'] = not cleaned
+                params["clean"] = "false"
             try:
                 response = self.session.post(url, json=chunk, params=params)
                 response.raise_for_status()

setup.py

@@ -34,6 +34,8 @@
             "wheel",
             "pytest",
             "pytest-mock >= 1.10.0",
+            "types-requests",
+            "types-setuptools",
         ]
     },
     entry_points={