Add condition to check dependency MeshSDFilter folder #1704
Conversation
|
Sorry, but this PR is not valid or at least incomplete. I think this condition is meant to check that the submodules have been retrieved and exit early. There is not only MeshSDFilter but also NanoFlann. If we merge this PR, then we should add a second test for nanoflann submodule. |
| @@ -178,7 +178,7 @@ endmacro(add_target_properties) | |||
| # ============================================================================== | |||
| # Check that submodule have been initialized and updated | |||
| # ============================================================================== | |||
| if(NOT EXISTS ${CMAKE_CURRENT_SOURCE_DIR}/dependencies/MeshSDFilter/CMakeLists.txt) | |||
| if(ALICEVISION_USE_MESHSDFILTER AND NOT EXISTS ${CMAKE_CURRENT_SOURCE_DIR}/dependencies/MeshSDFilter/CMakeLists.txt) | |||
There was a problem hiding this comment.
Sorry, but this PR is not valid or at least incomplete.
I think this condition is meant to check that the submodule_s_ have been retrieved and exit early. There is not only MeshSDFilter but also NanoFlann. If we merge this PR, then we should add a second test for nanoflann submodule.
But this is only for MeshSDFilter, right?
That's the point. Nanoflann is mandatory and we don't check it, MeshSDFilter and we check. So either we don't check either of them or we check both of them. MeshSDFilter should be checked the way this PR suggests because it's optional, if anything we should add a check for nanoflann |
Should I also add check for NanoFlann in this PR? |
|
Ping @simogasp for review again. |
|
@JackBoosY Thanks! |
Implementation remarks
FTR #767 (comment)
The check should requires
ALICEVISION_USE_MESHSDFILTERisON.