Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add condition to check dependency MeshSDFilter folder #1704

Merged
merged 5 commits into from
Apr 28, 2024
Merged

Add condition to check dependency MeshSDFilter folder #1704

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d85de15
Add condition to check dependency MeshSDFilter folder
Apr 10, 2024
54fd84e
Merge branch 'develop' into jack/fix_condition
JackBoosY Apr 11, 2024
b95b7fe
Restore changes
JackBoosY Apr 11, 2024
75ffd33
Merge branch 'develop' into jack/fix_condition
JackBoosY Apr 12, 2024
3225e72
Merge branch 'develop' into jack/fix_condition
JackBoosY Apr 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ endmacro(add_target_properties)
# ==============================================================================
# Check that submodule have been initialized and updated
# ==============================================================================
if(NOT EXISTS ${CMAKE_CURRENT_SOURCE_DIR}/dependencies/MeshSDFilter/CMakeLists.txt)
if(ALICEVISION_USE_MESHSDFILTER AND NOT EXISTS ${CMAKE_CURRENT_SOURCE_DIR}/dependencies/MeshSDFilter/CMakeLists.txt)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but this PR is not valid or at least incomplete.

I think this condition is meant to check that the submodule_s_ have been retrieved and exit early. There is not only MeshSDFilter but also NanoFlann. If we merge this PR, then we should add a second test for nanoflann submodule.

But this is only for MeshSDFilter, right?

message(FATAL_ERROR
"\n submodule(s) are missing, please update your repository:\n"
" > git submodule update -i\n")
Expand Down
Loading