feat(advanced): Provider trait over reth-db
#144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
reviewed
Sep 25, 2024
yash-atreya
changed the title
Provider trait over reth-db
mattsse
requested changes
Sep 26, 2024
Comment on lines
+208
to
+210
| struct WrapProviderFactory { | ||
| inner: Arc<ProviderFactory<NodeTypesWithDBAdapter<EthereumNode, Arc<DatabaseEnv>>>>, | ||
| } |
There was a problem hiding this comment.
I'd prefer if we could operate entirely on traits here
ptal @klkvr
There was a problem hiding this comment.
it's a bit tricky rn because ProviderFactory implements getters for state providers directly and not through trait: https://github.com/paradigmxyz/reth/blob/ba4e41110b87cccda21d588e0a59bc94ee910e80/crates/storage/provider/src/providers/database/mod.rs#L164
however, we could use TryIntoHistoricalStateProvider trait directly on db provider
so the resulting bound would look like DatabaseProviderFactory<Provider: TryIntoHistoricalStateProvider> + BlockNumReader
klkvr
reviewed
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In the latest release of alloy-0.3.6,
ProviderCallwas introduced as a return type in theProvidertrait.ProviderCallenables to fetch the result of an RPC call from any data source such as the node's db, cache etc.More on this can be found here alloy-rs/alloy#788
Solution
Example showing how to wrap the
Providertrait over reth-db and useProviderCallto fetch responses from the db directly.PR Checklist