Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(advanced):
Provider
trait over reth-db #144base: main
Are you sure you want to change the base?
feat(advanced):
Provider
trait over reth-db #144Changes from 11 commits
5eae85e
b96576a
d91a8ba
aa44fe3
9f44996
bcbda72
106c26b
6f6c6d5
ea2b352
b095099
9c84bbf
f51d6b1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer if we could operate entirely on traits here
ptal @klkvr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a bit tricky rn because
ProviderFactory
implements getters for state providers directly and not through trait: https://github.com/paradigmxyz/reth/blob/ba4e41110b87cccda21d588e0a59bc94ee910e80/crates/storage/provider/src/providers/database/mod.rs#L164however, we could use
TryIntoHistoricalStateProvider
trait directly on db providerso the resulting bound would look like
DatabaseProviderFactory<Provider: TryIntoHistoricalStateProvider> + BlockNumReader