-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update L1Tx ref types to include multiple proto ops per tx #618
Conversation
da8be4c
to
e78e71d
Compare
Commit: 1278523 SP1 Performance Test Results
|
0a66e86
to
d8f04ee
Compare
6c885d6
to
505735d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to rework the data structures a little bit to make them more accurately reflect the design we have now.
Also, see the visitor-oriented approach. The goal with that was to decouple the "figuring out what to do with protocol ops we get" from the "actually finding the protocol ops" parts so that handling can be different depending on if it's in the proof or in the reader.
d8f04ee
to
3eb992c
Compare
9991efb
to
501dbc9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Discussed in core sync, leaving review here to continue work.)
3eb992c
to
d7dc0a9
Compare
fcf9d7c
to
5365d49
Compare
Updated the description and made changes. |
e8ee5db
to
c3f0ec2
Compare
b93aed9
to
16b29d2
Compare
16b29d2
to
aecb268
Compare
Merging to unblock some new work. |
Description
This PR does the following:
BlockIndexer
that takes L1 blocks and parses/extracts/processes relevant data andOpsVisitor
that is to be used by a "BlockIndexer
" which allows for different processing of relevant info found in transactions.OpsVisitor
:ClientOpsVisitor
andProverOpsVisitor
which differ in thatProverOpsVisitor
is intended to just extract DA commitments from transactions efficiently without actually storing/processing the whole da content.filter_protocol_op_tx_refs
function whose functionality is better provided byBlockIndexer
andOpsVisitor
s.Type of Change
Notes to Reviewers
Checklist
Related Issues
STR-935