Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update L1Tx ref types to include multiple proto ops per tx #618

Merged
merged 22 commits into from
Feb 6, 2025
+1,386 −683

l1tx: cleanup

aecb268
Select commit
Loading
Failed to load commit list.
Merged

Update L1Tx ref types to include multiple proto ops per tx #618

l1tx: cleanup
aecb268
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 6, 2025 in 0s

54.87% (+0.18%) compared to 2830f20

View this Pull Request on Codecov

54.87% (+0.18%) compared to 2830f20

Details

Codecov Report

Attention: Patch coverage is 82.68349% with 151 lines in your changes missing coverage. Please review.

Project coverage is 54.87%. Comparing base (2830f20) to head (aecb268).

Files with missing lines Patch % Lines
crates/l1tx/src/messages.rs 29.72% 52 Missing ⚠️
crates/state/src/tx.rs 0.00% 21 Missing ⚠️
crates/btcio/src/reader/tx_indexer.rs 91.62% 19 Missing ⚠️
crates/consensus-logic/src/l1_handler.rs 0.00% 13 Missing ⚠️
crates/proof-impl/btc-blockspace/src/tx_indexer.rs 92.52% 13 Missing ⚠️
crates/btcio/src/reader/query.rs 47.05% 9 Missing ⚠️
crates/l1tx/src/filter/indexer.rs 77.50% 9 Missing ⚠️
crates/l1tx/src/filter/mod.rs 96.24% 5 Missing ⚠️
...tes/sequencer/src/block_template/block_assembly.rs 0.00% 4 Missing ⚠️
crates/proof-impl/btc-blockspace/src/filter.rs 50.00% 2 Missing ⚠️
... and 3 more 
@@            Coverage Diff             @@
##             main     #618      +/-   ##
==========================================
+ Coverage   54.68%   54.87%   +0.18%     
==========================================
  Files         314      317       +3     
  Lines       33580    33973     +393     
==========================================
+ Hits        18363    18641     +278     
- Misses      15217    15332     +115
Files with missing lines Coverage Δ
crates/btcio/src/test_utils.rs 62.10% <100.00%> (+6.00%) ⬆️
crates/btcio/src/writer/builder.rs 98.03% <ø> (ø)
crates/chaintsn/src/transition.rs 82.86% <100.00%> (ø)
crates/l1tx/src/deposit/deposit_request.rs 98.84% <ø> (ø)
crates/l1tx/src/deposit/deposit_tx.rs 96.10% <ø> (ø)
crates/l1tx/src/deposit/test_utils.rs 100.00% <ø> (ø)
crates/l1tx/src/envelope/parser.rs 97.50% <100.00%> (ø)
crates/rocksdb-store/src/l1/db.rs 97.65% <100.00%> (ø)
crates/rocksdb-store/src/l2/db.rs 99.42% <100.00%> (ø)
crates/state/src/l1/tx.rs 64.70% <100.00%> (-2.95%) ⬇️
... and 15 more

... and 5 files with indirect coverage changes

View more details on Codecov