Merge pull request #25 from answear/dev

Fix setting 'false' as filter
answear · Jul 21, 2020 · 1beb6fe · 1beb6fe
2 parents 1b70ca0 + d9c3ab3
commit 1beb6fe
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/LuigisBoxBundle/ValueObject/SearchUrlBuilder.php b/src/LuigisBoxBundle/ValueObject/SearchUrlBuilder.php
@@ -127,7 +127,7 @@ public function addFilter(string $key, $value): self
         if (\is_string($this->filters[$key])) {
             $this->filters[$key] = [$this->filters[$key]];
         }
-        $this->filters[$key][] = (string) $value;
+        $this->filters[$key][] = (string) (false === $value ? '0' : $value);
 
         $this->filters[$key] = array_unique($this->filters[$key]);
 
@@ -167,7 +167,7 @@ public function addMustFilter(string $key, $value): self
         if (\is_string($this->mustFilters[$key])) {
             $this->mustFilters[$key] = [$this->mustFilters[$key]];
         }
-        $this->mustFilters[$key][] = (string) $value;
+        $this->mustFilters[$key][] = (string) (false === $value ? '0' : $value);
 
         $this->mustFilters[$key] = array_unique($this->mustFilters[$key]);
 

diff --git a/tests/Unit/ValueObject/SearchUrlBuilderTest.php b/tests/Unit/ValueObject/SearchUrlBuilderTest.php
@@ -49,6 +49,14 @@ public function buildValidUrlTest(): void
         ];
         $this->assertOk($query, $searchBuilder);
 
+        $searchBuilder->addFilter('available', false);
+        $query['f[]'] = [
+            'category:Top & Top',
+            'category:Jeans',
+            'available:0',
+        ];
+        $this->assertOk($query, $searchBuilder);
+
         $searchBuilder->resetFilters();
         $searchBuilder->setFilters(
             [