Support symfony 7 #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wiktor6
force-pushed
the
support-symfony-7
branch
from
0fb85a1
to
72d1292
Compare
lukasz-falda
reviewed
Oct 1, 2024
phpunit.xml.dist
Outdated
| @@ -1,29 +1,20 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | |||
| xsi:noNamespaceSchemaLocation="http://schema.phpunit.de/6.1/phpunit.xsd" | |||
| xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.5/phpunit.xsd" | |||
There was a problem hiding this comment.
use vendor/phpunit/phpunit/phpunit.xsd instead
| public function __construct(string $message, Request $request) | ||
| public function __construct( | ||
| string $message, | ||
| public readonly Request $request) |
| string $message, | ||
| public readonly ResponseInterface $response, | ||
| public readonly Request $request, | ||
| ?\Throwable $previous = null) |
| public function resetHeaders(): void | ||
| { | ||
| $this->headers = []; | ||
| } | ||
|
|
||
| /** | ||
| * @deprecated use getAuthorizationHeaders method instead | ||
| */ |
There was a problem hiding this comment.
write about it on release note
| private $objects; | ||
|
|
||
| public function __construct(array $objects) | ||
| public function __construct(public array $objects) |
| * @param bool|int|string $value | ||
| */ | ||
| public function addMustFilter(string $key, $value): self | ||
| public function addMustFilter(string $key, bool|int|string $value): self | ||
| { |
There was a problem hiding this comment.
below conditions can be removed
There was a problem hiding this comment.
Then it will throw different exception, is it ok?
| * @dataProvider \Answear\LuigisBoxBundle\Tests\DataProvider\RequestDataProvider::forContentUpdate() | ||
| */ | ||
| #[Test] | ||
| #[DataProvider('forContentUpdate')] |
There was a problem hiding this comment.
why not from RequestDataProvider? It is impossible to load from external static method?
bmulawa
approved these changes
Oct 1, 2024
lukasz-falda
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AC