Fix percentage distance methods #339
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…by update to get_coordinate_from_distance methods.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #339 +/- ##
==========================================
+ Coverage 87.08% 87.20% +0.12%
==========================================
Files 20 20
Lines 2028 2048 +20
==========================================
+ Hits 1766 1786 +20
Misses 262 262 |
@JackB-Ansys You will need to improve the existing tests to cover all the new lines of code |
jgsdavies
requested changes
Jul 23, 2024
| return Coordinate(x, y) | ||
|
|
||
| def get_coordinate_from_distance(self, ref_coordinate, distance): | ||
| def get_coordinate_from_distance( |
There was a problem hiding this comment.
I like this change. @matthewAnsys thoughts?
| @@ -531,14 +531,31 @@ def test_line_length(): | |||
| assert line.length == sqrt(2) | |||
|
|
|||
|
|
|||
| def test_arc_get_coordinate_from_percentage_distance(): | |||
| def test_arc_get_coordinate_from_fractional_distance(): | |||
There was a problem hiding this comment.
Can we make sure this also works for arcs with negative radius
|
Needs merge from main |
…entage_distance_methods # Conflicts: # src/ansys/motorcad/core/geometry.py # tests/test_geometry.py
… tests for new optional arguments)
…ts for warnings when multiple arguments are given)
…t for arc drawn with negative radius)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate get_coordinate_from_percentage_distance methods because these actually use fractional distances. Replace this functionality by adding optional arguments for get_coordinate_from_distance, where user can specify a percentage or fraction instead of specifying an absolute distance.