Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix percentage distance methods #339
base: main
Are you sure you want to change the base?
Fix percentage distance methods #339
Changes from all commits
4569d36
cd113d4
abfe2a3
0f9f663
4009764
6f112a0
35e19a5
6ab1540
3343f34
ffa98dc
741b597
da2b09d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this change. @matthewAnsys thoughts?
Check warning on line 1000 in src/ansys/motorcad/core/geometry.py
Codecov / codecov/patch
src/ansys/motorcad/core/geometry.py#L1000
Check warning on line 1187 in src/ansys/motorcad/core/geometry.py
Codecov / codecov/patch
src/ansys/motorcad/core/geometry.py#L1187
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make sure this also works for arcs with negative radius