-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AIP-84: Migrating GET queued asset events for DAG to fastAPI #43934
AIP-84: Migrating GET queued asset events for DAG to fastAPI #43934
Conversation
3af2873
to
2cd5dc1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions
@pierrejeambrun FYI, I have pushed the changes for all the "resolved" comments. The rest are open for input from you. EDIT: I kept the endpoint at public/dags.py cos if I move to assets, the path will become: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small suggestions / questions almost ready
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As many of other PRs depends on this one, to try to make them move forward I added a few commits, I think it's ready
related: #42370
Migrating the GET queued asset events for a DAG endpoint to fast API.
Setup:
Created producer and consumer dags:
Paused one producer while running the other to generate queued events
Responses:
Legacy
FastAPI
With time filtering:
(Beyond creation time)
(Beyond creation time)
Swagger spec: (maintained under dag section)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.