Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAMEL-20115: Support for Start Date and End Date in camel-quartz #12089

Closed
wants to merge 3 commits into from
Closed

CAMEL-20115: Support for Start Date and End Date in camel-quartz #12089

wants to merge 3 commits into from

Conversation

prasanthrao
Copy link
Contributor

@prasanthrao prasanthrao commented Nov 20, 2023 •
edited
Loading

Description

Fix for CAMEL-20115 Support for Start Date and End Date in camel-quartz

Target

  • I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

oscerd
oscerd reviewed Nov 20, 2023
View reviewed changes
Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, but I think it should go on main, since it is a new feature.

Fix: Trigger Expiry check in CamelJob
d9d683b 
Expiry check missed the case when both start and end time are provided
@oscerd
Copy link
Contributor

oscerd commented Nov 20, 2023

Shouldn't this need to go on main first?

@prasanthrao
Copy link
Contributor Author

prasanthrao commented Nov 20, 2023 •
edited
Loading

Shouldn't this need to go on main first?

I have created #12098 for the main branch

@prasanthrao prasanthrao mentioned this pull request Nov 20, 2023
Merged
1 task
@davsclaus
Copy link
Contributor

3.1.4 is EOL and we should only do this change in newer releases

@davsclaus davsclaus closed this Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscerd oscerd oscerd left review comments

@davsclaus davsclaus davsclaus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prasanthrao @oscerd @davsclaus