Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAMEL-20115: Support for Start Date and End Date in camel-quartz #12098

Merged
merged 4 commits into from
Nov 24, 2023
Merged

CAMEL-20115: Support for Start Date and End Date in camel-quartz #12098

merged 4 commits into from
Nov 24, 2023

Conversation

prasanthrao
Copy link
Contributor

@prasanthrao prasanthrao commented Nov 20, 2023 •
edited
Loading

Description

Cherry-pick of #12089

Target

  • [ x] I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • [ x] If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • [x ] I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

@github-actions GitHub Actions
Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@prasanthrao prasanthrao mentioned this pull request Nov 20, 2023
Closed
4 tasks
@oscerd
Copy link
Contributor

oscerd commented Nov 20, 2023 •
edited by github-actions bot
Loading

/component-test quartz

Result ❌ The tests failed please check the logs

@github-actions GitHub Actions
Copy link
Contributor

🤖 The Apache Camel test robot will run the tests for you 👍

@davsclaus
Copy link
Contributor

org.apache.camel.component.quartz.QuartzManuallyTriggerJobTest.testQuartzCronRoute 10.54s FAILURE
org.apache.camel.component.quartz.QuartzAddRoutesAfterCamelContextStartedTest.testAddRoutes 10.96s FAILURE
org.apache.camel.component.quartz.QuartzAddDynamicRouteTest.testAddDynamicRoute 11.35s FAILURE

@davsclaus
Copy link
Contributor

Do you have test errors locally ?

@prasanthrao
Copy link
Contributor Author

prasanthrao commented Nov 20, 2023 •
edited
Loading

I might have found the issue. In QuartzEndpoint during createTrigger, the startAt is configured always to be few duration later than the current time but the new change in CamelJob only account for after time and not the exact match. Fixing the issue in the next commit

orpiske
orpiske approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@orpiske orpiske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, LGTM.

@davsclaus davsclaus merged commit 2a90c15 into apache:main Nov 24, 2023
2 of 3 checks passed
davsclaus pushed a commit that referenced this pull request Nov 24, 2023
@prasanthrao @davsclaus
CAMEL-20115: Support for Start Date and End Date in camel-quartz (#12098
b2f0e66 
)

* CAMEL-20115: Support for Start Date and End Date in camel-quartz

* Fix for exact match in CamelJob for fireTime

* Move to Date with Timezone format

* Updated adoc and removed string concatenation from Test

---------

Co-authored-by: Prasanth Rao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davsclaus davsclaus davsclaus approved these changes

@orpiske orpiske orpiske approved these changes

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
camel-4 components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prasanthrao @oscerd @davsclaus @orpiske