Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](complex-column)fix column bitmap with agg behavior #43228

Merged
merged 3 commits into from
Nov 6, 2024
Merged

[fix](complex-column)fix column bitmap with agg behavior #43228

merged 3 commits into from
Nov 6, 2024

Conversation

amorynan
Copy link
Contributor

@amorynan amorynan commented Nov 4, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Check List (For Committer)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No colde files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

  • Release note

    None

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@amorynan
Copy link
Contributor Author

amorynan commented Nov 4, 2024

only branch-2.0 need

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024

clang-tidy review says "All clean, LGTM! 👍"

@amorynan
Copy link
Contributor Author

amorynan commented Nov 5, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.85% (8157/21553)
Line Coverage: 29.56% (67120/227060)
Region Coverage: 29.04% (34615/119192)
Branch Coverage: 24.99% (17865/71492)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b40c3edfb1e079bde688c5032dec9dba12ac9585_b40c3edfb1e079bde688c5032dec9dba12ac9585/report/index.html

HappenLee
HappenLee reviewed Nov 5, 2024
View reviewed changes
be/src/vec/columns/column_complex.h Outdated
@@ -81,7 +81,8 @@ class ColumnComplexType final : public COWHelper<IColumn, ColumnComplexType<T>>
} else if constexpr (std::is_same_v<T, QuantileStateDouble>) {
pvalue->deserialize(Slice(pos, length));
} else {
LOG(FATAL) << "Unexpected type in column complex";
throw doris::Exception(ErrorCode::INTERNAL_ERROR, "Unexpected type in column complex");
__builtin_unreachable();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the func is void， seems no need add __builtin_unreachable()

HappenLee
HappenLee reviewed Nov 5, 2024
View reviewed changes
be/src/vec/columns/column_complex.h Outdated
@@ -124,12 +125,14 @@ class ColumnComplexType final : public COWHelper<IColumn, ColumnComplexType<T>>

[[noreturn]] void get_permutation(bool reverse, size_t limit, int nan_direction_hint,
IColumn::Permutation& res) const override {
LOG(FATAL) << "get_permutation not implemented";
throw doris::Exception(ErrorCode::INTERNAL_ERROR, "get_permutation not implemented");
__builtin_unreachable();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same to the up

HappenLee
HappenLee reviewed Nov 5, 2024
View reviewed changes
be/src/vec/columns/column_complex.h Outdated
}

[[noreturn]] const char* deserialize_and_insert_from_arena(const char* pos) override {
throw doris::Exception(ErrorCode::INTERNAL_ERROR,
"deserialize_and_insert_from_arena not implemented");
__builtin_unreachable();
LOG(FATAL) << "deserialize_and_insert_from_arena not implemented";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we delete the log(fatal)

@amorynan
Copy link
Contributor Author

amorynan commented Nov 5, 2024

run buildall

@amorynan amorynan requested a review from HappenLee November 5, 2024 05:45
@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.85% (8157/21553)
Line Coverage: 29.56% (67126/227056)
Region Coverage: 29.04% (34616/119188)
Branch Coverage: 24.99% (17866/71492)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b572696987074660c474444213b77fa12e3ab2e7_b572696987074660c474444213b77fa12e3ab2e7/report/index.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

clang-tidy review says "All clean, LGTM! 👍"

HappenLee
HappenLee approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Nov 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

PR approved by anyone and no changes requested.

xiaokang
xiaokang approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaokang xiaokang merged commit bf34be8 into apache:branch-2.0 Nov 6, 2024
21 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HappenLee HappenLee HappenLee approved these changes

@xiaokang xiaokang xiaokang approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. kind/test reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amorynan @doris-robot @xiaokang @HappenLee