-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](complex-column)fix column bitmap with agg behavior #43228
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -81,7 +81,8 @@ class ColumnComplexType final : public COWHelper<IColumn, ColumnComplexType<T>> | |
} else if constexpr (std::is_same_v<T, QuantileStateDouble>) { | ||
pvalue->deserialize(Slice(pos, length)); | ||
} else { | ||
LOG(FATAL) << "Unexpected type in column complex"; | ||
throw doris::Exception(ErrorCode::INTERNAL_ERROR, "Unexpected type in column complex"); | ||
__builtin_unreachable(); | ||
} | ||
} | ||
|
||
|
@@ -124,12 +125,14 @@ class ColumnComplexType final : public COWHelper<IColumn, ColumnComplexType<T>> | |
|
||
[[noreturn]] void get_permutation(bool reverse, size_t limit, int nan_direction_hint, | ||
IColumn::Permutation& res) const override { | ||
LOG(FATAL) << "get_permutation not implemented"; | ||
throw doris::Exception(ErrorCode::INTERNAL_ERROR, "get_permutation not implemented"); | ||
__builtin_unreachable(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same to the up |
||
} | ||
|
||
void get_indices_of_non_default_rows(IColumn::Offsets64& indices, size_t from, | ||
size_t limit) const override { | ||
LOG(FATAL) << "get_indices_of_non_default_rows not implemented"; | ||
throw doris::Exception(ErrorCode::INTERNAL_ERROR, "get_int not implemented"); | ||
__builtin_unreachable(); | ||
} | ||
[[noreturn]] ColumnPtr index(const IColumn& indexes, size_t limit) const override { | ||
LOG(FATAL) << "index not implemented"; | ||
|
@@ -205,10 +208,15 @@ class ColumnComplexType final : public COWHelper<IColumn, ColumnComplexType<T>> | |
// it's impossible to use ComplexType as key , so we don't have to implement them | ||
[[noreturn]] StringRef serialize_value_into_arena(size_t n, Arena& arena, | ||
char const*& begin) const override { | ||
LOG(FATAL) << "serialize_value_into_arena not implemented"; | ||
throw doris::Exception(ErrorCode::INTERNAL_ERROR, | ||
"serialize_value_into_arena not implemented"); | ||
__builtin_unreachable(); | ||
} | ||
|
||
[[noreturn]] const char* deserialize_and_insert_from_arena(const char* pos) override { | ||
throw doris::Exception(ErrorCode::INTERNAL_ERROR, | ||
"deserialize_and_insert_from_arena not implemented"); | ||
__builtin_unreachable(); | ||
LOG(FATAL) << "deserialize_and_insert_from_arena not implemented"; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should we delete the |
||
} | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the func is void, seems no need add
__builtin_unreachable()