fix: some rocksdb properties are counted multiple times #2589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
torwig
approved these changes
Oct 11, 2024
|
@sryanyuan Thank you for this fix. |
git-hulk
pushed a commit
that referenced
this pull request
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some rocksdb properties, such as
num_snapshots/num_running_flushes/num_running_compactions, are read directly from DB stats. However, usingGetAggregatedIntPropertycan cause the property values to be counted multiple times, resulting in a final value that is the original value multiplied by the number of column families. This can be misleading when troubleshooting performance issues, especially when compared to the rocksdb configuration field 'max_background_jobs'.