Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: some rocksdb properties are counted multiple times #2589

Merged
merged 2 commits into from
Oct 11, 2024
Merged

fix: some rocksdb properties are counted multiple times #2589

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7edb5ca
fix: some rocksdb properties are counted multiple times
tclxyxj25245 Oct 11, 2024
074d5b9
Merge branch 'unstable' into fix-rocksdb-property
git-hulk Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/server/server.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -853,13 +853,10 @@ void Server::GetRocksDBInfo(std::string *info) {
uint64_t num_immutable_tables = 0, memtable_flush_pending = 0, compaction_pending = 0;
uint64_t num_running_compaction = 0, num_live_versions = 0, num_super_version = 0, num_background_errors = 0;

db->GetAggregatedIntProperty("rocksdb.num-snapshots", &num_snapshots);
db->GetAggregatedIntProperty("rocksdb.size-all-mem-tables", &memtable_sizes);
db->GetAggregatedIntProperty("rocksdb.cur-size-all-mem-tables", &cur_memtable_sizes);
db->GetAggregatedIntProperty("rocksdb.num-running-flushes", &num_running_flushes);
db->GetAggregatedIntProperty("rocksdb.num-immutable-mem-table", &num_immutable_tables);
db->GetAggregatedIntProperty("rocksdb.mem-table-flush-pending", &memtable_flush_pending);
db->GetAggregatedIntProperty("rocksdb.num-running-compactions", &num_running_compaction);
db->GetAggregatedIntProperty("rocksdb.current-super-version-number", &num_super_version);
db->GetAggregatedIntProperty("rocksdb.background-errors", &num_background_errors);
db->GetAggregatedIntProperty("rocksdb.compaction-pending", &compaction_pending);
Expand All @@ -877,6 +874,11 @@ void Server::GetRocksDBInfo(std::string *info) {
db->GetIntProperty(subkey_cf_handle, rocksdb::DB::Properties::kBlockCachePinnedUsage, &block_cache_pinned_usage);
string_stream << "block_cache_pinned_usage[" << subkey_cf_handle->GetName() << "]:" << block_cache_pinned_usage
<< "\r\n";

// All column faimilies share the same property of the DB, so it's good to count a single one.
db->GetIntProperty(subkey_cf_handle, rocksdb::DB::Properties::kNumSnapshots, &num_snapshots);
db->GetIntProperty(subkey_cf_handle, rocksdb::DB::Properties::kNumRunningFlushes, &num_running_flushes);
db->GetIntProperty(subkey_cf_handle, rocksdb::DB::Properties::kNumRunningCompactions, &num_running_compaction);
}

for (const auto &cf_handle : *storage->GetCFHandles()) {
Expand Down
Loading