Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHOENIX-7118 Fix Shading Regressions in Spark Connector #116

Closed
wants to merge 1 commit into from

Conversation

stoty
Copy link
Contributor

@stoty stoty commented Nov 22, 2023

No description provided.

@stoty stoty marked this pull request as draft November 22, 2023 17:40
@stoty
Copy link
Contributor Author

stoty commented Nov 22, 2023

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 3m 23s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗 mvndep 10m 20s Maven dependency ordering for branch
+1 💚 mvninstall 8m 34s master passed
+1 💚 compile 1m 11s master passed
+1 💚 javadoc 0m 36s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 52s Maven dependency ordering for patch
-1 ❌ mvninstall 3m 15s root in the patch failed.
-1 ❌ compile 0m 57s root in the patch failed.
-1 ❌ javac 0m 57s root in the patch failed.
-1 ❌ whitespace 0m 0s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚 xml 0m 3s The patch has no ill-formed XML file.
-1 ❌ javadoc 0m 19s root in the patch failed.
_ Other Tests _
-1 ❌ unit 10m 33s root in the patch failed.
-1 ❌ asflicense 0m 18s The patch generated 2 ASF License warnings.
41m 0s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-116/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #116
Optional Tests dupname asflicense javac javadoc unit xml compile
uname Linux c17bcc4942f7 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-connectors-personality.sh
git revision master / 26c1aba
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
mvninstall https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-116/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-116/1/artifact/yetus-general-check/output/patch-compile-root.txt
javac https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-116/1/artifact/yetus-general-check/output/patch-compile-root.txt
whitespace https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-116/1/artifact/yetus-general-check/output/whitespace-eol.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-116/1/artifact/yetus-general-check/output/patch-javadoc-root.txt
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-116/1/artifact/yetus-general-check/output/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-116/1/testReport/
asflicense https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-116/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt
Max. process+thread count 1642 (vs. ulimit of 30000)
modules C: phoenix5-spark-shaded phoenix5-spark3-shaded . U: .
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-116/1/console
versions git=2.7.4 maven=3.3.9
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stoty
Copy link
Contributor Author

stoty commented Nov 22, 2023

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 10s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗 mvndep 10m 58s Maven dependency ordering for branch
+1 💚 mvninstall 8m 22s master passed
+1 💚 compile 1m 10s master passed
+1 💚 javadoc 0m 58s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 4m 40s the patch passed
+1 💚 compile 1m 14s the patch passed
-1 ❌ javac 1m 14s root generated 20 new + 1388 unchanged - 20 fixed = 1408 total (was 1408)
-1 ❌ whitespace 0m 0s The patch has 6 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚 xml 0m 5s The patch has no ill-formed XML file.
-1 ❌ javadoc 0m 21s root generated 20 new + 1401 unchanged - 20 fixed = 1421 total (was 1421)
_ Other Tests _
-1 ❌ unit 10m 7s root in the patch failed.
-1 ❌ asflicense 0m 30s The patch generated 3 ASF License warnings.
39m 55s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-116/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #116
Optional Tests dupname asflicense javac javadoc unit xml compile
uname Linux 590b9e5c4cb5 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-connectors-personality.sh
git revision master / 26c1aba
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
javac https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-116/2/artifact/yetus-general-check/output/diff-compile-javac-root.txt
whitespace https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-116/2/artifact/yetus-general-check/output/whitespace-eol.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-116/2/artifact/yetus-general-check/output/diff-javadoc-javadoc-root.txt
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-116/2/artifact/yetus-general-check/output/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-116/2/testReport/
asflicense https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-116/2/artifact/yetus-general-check/output/patch-asflicense-problems.txt
Max. process+thread count 1886 (vs. ulimit of 30000)
modules C: phoenix5-hive phoenix5-hive-shaded phoenix5-spark-shaded phoenix5-spark3-shaded . U: .
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-116/2/console
versions git=2.7.4 maven=3.3.9
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stoty
Copy link
Contributor Author

stoty commented Nov 27, 2023

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 3m 16s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗 mvndep 10m 17s Maven dependency ordering for branch
+1 💚 mvninstall 11m 36s master passed
+1 💚 compile 1m 20s master passed
+1 💚 javadoc 0m 36s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
-1 ❌ mvninstall 3m 58s root in the patch failed.
-1 ❌ compile 0m 59s root in the patch failed.
-1 ❌ javac 0m 59s root in the patch failed.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 2s The patch has no ill-formed XML file.
-1 ❌ javadoc 0m 19s root in the patch failed.
_ Other Tests _
-1 ❌ unit 9m 48s root in the patch failed.
-1 ❌ asflicense 0m 17s The patch generated 2 ASF License warnings.
43m 12s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-116/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #116
Optional Tests dupname asflicense javac javadoc unit xml compile
uname Linux fe9e655d0c59 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-connectors-personality.sh
git revision master / 26c1aba
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
mvninstall https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-116/3/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-116/3/artifact/yetus-general-check/output/patch-compile-root.txt
javac https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-116/3/artifact/yetus-general-check/output/patch-compile-root.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-116/3/artifact/yetus-general-check/output/patch-javadoc-root.txt
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-116/3/artifact/yetus-general-check/output/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-116/3/testReport/
asflicense https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-116/3/artifact/yetus-general-check/output/patch-asflicense-problems.txt
Max. process+thread count 1854 (vs. ulimit of 30000)
modules C: phoenix5-spark-shaded phoenix5-spark3-shaded . U: .
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-116/3/console
versions git=2.7.4 maven=3.3.9
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stoty stoty changed the title Phoenix 7118 PHOENIX-7118 Fix Shading Regressions in Spark Connector Nov 27, 2023
@stoty stoty marked this pull request as ready for review November 27, 2023 19:09
@stoty stoty requested a review from richardantal November 27, 2023 19:09
@stoty stoty closed this Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant