Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor cmpd's role definition #8416

Merged
merged 41 commits into from
Jan 20, 2025
Merged

feat: refactor cmpd's role definition #8416

merged 41 commits into from
Jan 20, 2025

Conversation

cjc7373
Copy link
Contributor

@cjc7373 cjc7373 commented Nov 6, 2024

fixes #8377

@github-actions github-actions bot added the size/XXL Denotes a PR that changes 1000+ lines. label Nov 6, 2024
@cjc7373 cjc7373 changed the title feat: refactor role feat: refactor cmpd's role definition Nov 6, 2024
@cjc7373 cjc7373 force-pushed the feature/refactor-role branch from b18c91c to deaf5f1 Compare November 6, 2024 15:50
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 83.87097% with 5 lines in your changes missing coverage. Please review.

Project coverage is 60.51%. Comparing base (982672d) to head (adbf63c).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...controller/builder/builder_component_definition.go 0.00% 4 Missing ⚠️
pkg/controller/component/its_convertor.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8416      +/-   ##
==========================================
+ Coverage   60.34%   60.51%   +0.17%     
==========================================
  Files         381      381              
  Lines       46215    46251      +36     
==========================================
+ Hits        27889    27990     +101     
+ Misses      15654    15588      -66     
- Partials     2672     2673       +1     
Flag Coverage Δ
unittests 60.51% <83.87%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cjc7373 cjc7373 marked this pull request as ready for review November 8, 2024 09:49
@cjc7373 cjc7373 force-pushed the feature/refactor-role branch from 752aefa to 90b8f22 Compare November 11, 2024 06:29
@apecloud-bot apecloud-bot added the approved PR Approved Test label Jan 20, 2025
@cjc7373 cjc7373 merged commit 40608e5 into main Jan 20, 2025
36 checks passed
@cjc7373 cjc7373 deleted the feature/refactor-role branch January 20, 2025 09:22
@github-actions github-actions bot added this to the Release 0.9.3 milestone Jan 20, 2025
@cjc7373
Copy link
Contributor Author

cjc7373 commented Jan 20, 2025

/cherry-pick release-1.0-beta

@apecloud-bot
Copy link
Collaborator

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/12866628817

apecloud-bot pushed a commit that referenced this pull request Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] refactor cmpd's roles
4 participants